Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] IconPath introduced as a shared class #14579

Closed
Tracked by #14584
rschnekenbu opened this issue Dec 4, 2024 · 0 comments · Fixed by #14590
Closed
Tracked by #14584

[vscode] IconPath introduced as a shared class #14579

rschnekenbu opened this issue Dec 4, 2024 · 0 comments · Fixed by #14590
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility
Milestone
1.57.0

Comments

@rschnekenbu
Copy link
Contributor

IconPath was extracted as a new type, reused in various places (e.g. QuickPickItem, WorkspaceEditEntryMetadata, TreeItem, TerminalOptions, ExtensionTerminalOption, QuickInputButton, ChatParticipant, ChatResponseStream, ChatResponseReferencePart)

Theia.d.ts should be updated accordingly.
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Dec 4, 2024
@rschnekenbu rschnekenbu self-assigned this Dec 4, 2024
@rschnekenbu rschnekenbu mentioned this issue Dec 4, 2024
Open
10 tasks
rschnekenbu added a commit that referenced this issue Dec 4, 2024
@rschnekenbu
[vscode] refactor uri or light/dark uri or ThemeIcon as IconPath type
0d6fdd4 
fixes #14579

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit that referenced this issue Dec 5, 2024
@rschnekenbu
[vscode] refactor uri or light/dark uri or ThemeIcon as IconPath type
2325816 
fixes #14579

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Dec 5, 2024
Merged
2 tasks
rschnekenbu added a commit that referenced this issue Dec 9, 2024
@rschnekenbu
[vscode] refactor uri or light/dark uri or ThemeIcon as IconPath type (…
5e81662 
…#14590)

fixes #14579

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@jfaltermeier jfaltermeier added this to the 1.57.0 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.57.0
Development

Successfully merging a pull request may close this issue.

[vscode] refactor uri or light/dark uri or ThemeIcon as IconPath type eclipse-theia/theia
2 participants
@rschnekenbu @jfaltermeier