Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] some signature changes from [] to Array<> #14580

Closed
Tracked by #14584
rschnekenbu opened this issue Dec 4, 2024 · 0 comments · Fixed by #14593
Closed
Tracked by #14584

[vscode] some signature changes from [] to Array<> #14580

rschnekenbu opened this issue Dec 4, 2024 · 0 comments · Fixed by #14593
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility
Milestone
1.57.0

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Dec 4, 2024 •
edited
Loading

CodeActionProvider#provideCodeActions() signature has changed from (Command | T)[] to Array<Command | T>
Same for one of the ShellExecution constructors.

This will also covers changes to AI and LLM support

  • LanguageModelChatMessage constructor & content from XX[] to Array + static utilities
  • LanguageModelToolResultPart content from XX[] to Array
  • LanguageModelToolResult content from XX[] to Array
  • PreparedToolInvocation invocationMessage now supports also MarkdownString

[new edit] This can also cover evolution on proposed API mappedEditProviders, to avoid too many small PRs.
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Dec 4, 2024
@rschnekenbu rschnekenbu self-assigned this Dec 4, 2024
This was referenced Dec 4, 2024
Open
Closed
@rschnekenbu rschnekenbu changed the title [vscode] CodeActionProvider#provideCodeActions() signature changes [vscode] some signature changes from [] to Array<> Dec 5, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 5, 2024
@rschnekenbu
[vscode] trivial changes on signature with Array
7a3b28e 
fixes eclipse-theia#14580

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Dec 5, 2024
Merged
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 9, 2024
@rschnekenbu
[vscode] trivial changes on signature with Array
0c86254 
fixes eclipse-theia#14580

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
This was referenced Dec 9, 2024
Closed
Open
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 10, 2024
@rschnekenbu
[vscode] trivial changes on signature with Array
4b0d5e8 
fixes eclipse-theia#14580

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@jfaltermeier jfaltermeier added this to the 1.57.0 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.57.0
Development

Successfully merging a pull request may close this issue.

[vscode] trivial changes on signature with Array eclipsesource/theia
2 participants
@rschnekenbu @jfaltermeier