[git] Error when restoring the state of the Git Commit Details view #1770
Comments
|
This is due to the incorrect |
|
I cannot observe this error from my environment. Or maybe I misunderstand the steps to reproduce ?
|
|
Click here:
|
|
@elaihau, just in case you start working on this, we need to consider whether we want to switch from the epoch number to the ISO string representation of the author-date. This was originally proposed here: #1754 (comment) |
vince-fugnitto
added a commit
that referenced
this issue
Nov 7, 2018
Fixes #1770 Fixes #1754 - Fixes error thrown when attempting to perform `Date.toLocaleDateString` in the `git-commit-detail-widget`. - Fixes error thrown when attempting to iterate over `fileChangeNodes` and it is `undefined`. - Fix typo when no git history is available - Simplify logic in `addCommits` Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Nov 7, 2018
Fixes #1770 Fixes #1754 - Fixes error thrown when attempting to perform `Date.toLocaleDateString` in the `git-commit-detail-widget`. - Fixes error thrown when attempting to iterate over `fileChangeNodes` and it is `undefined`. - Fix typo when no git history is available - Simplify logic in `addCommits` - Refactor `epoch` time to instead use `ISO` strings Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added a commit
that referenced
this issue
Nov 8, 2018
Fixes #1770 Fixes #1754 - Fixes error thrown when attempting to perform `Date.toLocaleDateString` in the `git-commit-detail-widget`. - Fixes error thrown when attempting to iterate over `fileChangeNodes` and it is `undefined`. - Simplify logic in `addCommits` - Refactor `epoch` time to instead use `ISO` strings Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
kittaakos
pushed a commit
that referenced
this issue
Nov 8, 2018
Fixes #1770 Fixes #1754 - Fixes error thrown when attempting to perform `Date.toLocaleDateString` in the `git-commit-detail-widget`. - Fixes error thrown when attempting to iterate over `fileChangeNodes` and it is `undefined`. - Simplify logic in `addCommits` - Refactor `epoch` time to instead use `ISO` strings Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Closed
bogthe
pushed a commit
to ARMmbed/theia
that referenced
this issue
Jan 21, 2019
Fixes eclipse-theia#1770 Fixes eclipse-theia#1754 - Fixes error thrown when attempting to perform `Date.toLocaleDateString` in the `git-commit-detail-widget`. - Fixes error thrown when attempting to iterate over `fileChangeNodes` and it is `undefined`. - Simplify logic in `addCommits` - Refactor `epoch` time to instead use `ISO` strings Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com> Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
logger.ts:62 TypeError: authorDate.toLocaleDateString is not a function at GitCommitDetailWidget.../../packages/git/lib/browser/history/git-commit-detail-widget.js.GitCommitDetailWidget.renderDiffListHeader (git-commit-detail-widget.ts:63) at GitCommitDetailWidget.../../packages/git/lib/browser/diff/git-diff-widget.js.GitDiffWidget.render (git-diff-widget.ts:105) at GitCommitDetailWidget.../../packages/core/lib/browser/widgets/virtual-widget.js.VirtualWidget.onUpdateRequest (virtual-widget.ts:25) at GitCommitDetailWidget.../../packages/git/lib/browser/git-navigable-list-widget.js.GitNavigableListWidget.onUpdateRequest (git-navigable-list-widget.ts:45) at GitCommitDetailWidget.../../node_modules/@phosphor/widgets/lib/widget.js.Widget.processMessage (widget.js:489) at invokeHandler (index.js:433) at sendMessage (index.js:169) at runMessageLoop (index.js:483)`The text was updated successfully, but these errors were encountered: