Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mini-browser] after refresh on a change an editor lose focus #2890

Closed
akosyakov opened this issue Sep 16, 2018 · 0 comments
Closed

[mini-browser] after refresh on a change an editor lose focus #2890

akosyakov opened this issue Sep 16, 2018 · 0 comments
Assignees
@akosyakov
Labels
bug bugs found in the application mini-browser issues related to the mini-browser

Comments

@akosyakov
Copy link
Member

akosyakov commented Sep 16, 2018 •
edited
Loading

When I edit and auto compile code with mini-browser opened, after refresh an editor does not have a focus anymore.

Reproducible with http://gitpod.io#https://github.com/akosyakov/gtr-cof
@akosyakov akosyakov added mini-browser issues related to the mini-browser bug bugs found in the application labels Sep 16, 2018
@akosyakov akosyakov self-assigned this Nov 21, 2018
@akosyakov akosyakov mentioned this issue Nov 21, 2018
Closed
akosyakov added a commit that referenced this issue Nov 22, 2018
@akosyakov
fix #2890: don't focus mini-browser iframe by default
3382d34 
There can be different causes to reload iframe, e.g. a dev server can trigger it. The iframe should not steal focus on each reload, but only if a user explicitly requested it, i.e. by clicking the refresh button.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 22, 2018
@akosyakov
fix #2890: don't focus mini-browser iframe by default
1dc8397 
There can be different causes to reload iframe, e.g. a dev server can trigger it. The iframe should not steal focus on each reload, but only if a user explicitly requested it, i.e. by clicking the refresh button.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
@akosyakov
fix eclipse-theia#2890: don't focus mini-browser iframe by default
0be8bcd 
There can be different causes to reload iframe, e.g. a dev server can trigger it. The iframe should not steal focus on each reload, but only if a user explicitly requested it, i.e. by clicking the refresh button.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application mini-browser issues related to the mini-browser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov