Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug] New thread detection removes stopped state #3601

Closed
thegecko opened this issue Nov 23, 2018 · 1 comment
Closed

[debug] New thread detection removes stopped state #3601

thegecko opened this issue Nov 23, 2018 · 1 comment
Assignees

Comments

@thegecko
Copy link
Member

If a new thread is detected, the known threads are updated.

As this new thread information no longer contains any stoppedDetails, if the debug is in a stopped state, this state is no longer reflected in the UI and instead looks like it is running.

This is because the stopped state is entirely dependent on the existence of stoppedDetails being added by the last thread update.

This issue is especially apparent during the startup stages in a slow debug adapter which has a breakpoint at it's point of entry. This is primarily due to the delay introduced by debouncing the thread calls.

Removing the debouncing fixes this issue in the case of the debug-cortex plugin, but this wouldn't fix a scenario when a new thread is started during debug.

I'm happy to open a PR to remove the debouncing, but would like opinions or other suggestions.

Thoughts @akosyakov @simark @marcdumais-work ?

@akosyakov akosyakov self-assigned this Nov 23, 2018
akosyakov added a commit that referenced this issue Nov 23, 2018
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member

stoppedDetails should be updated only by stop event, never by other clients

thegecko pushed a commit to ARMmbed/theia that referenced this issue Nov 23, 2018
…d event

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
…d event

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants