Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git] System/Global level credential.helper is not available from the electron application #3736

Closed
kittaakos opened this issue Dec 5, 2018 · 2 comments
Closed

[git] System/Global level credential.helper is not available from the electron application #3736

kittaakos opened this issue Dec 5, 2018 · 2 comments
Assignees
@kittaakos
Labels
electron issues related to the electron target git issues related to git

Comments

@kittaakos
Copy link
Contributor

This is a follow-up of #3397. Even if one configures the credential.helper for Git, Theia does not use the system Git by default, so it has no effect.

Related #3571.
@kittaakos kittaakos added git issues related to git electron issues related to the electron target labels Dec 5, 2018
@kittaakos kittaakos self-assigned this Dec 5, 2018
@svenefftinge
Copy link
Contributor

It could be set on the repo, but still that doesn't seem to be a good solution for the desktop world.
Is there a way to pass the credential.helper config with every command?

@kittaakos
Copy link
Contributor Author

kittaakos commented Dec 5, 2018 •
edited
Loading

credential.helper config

It is possible to pass in custom configs with the -c flag. Do you have an idea to tackle this?

I wanted to add a command: Use the global Git `credential.helper` in Theia.
This command will try to locate the system git, run git config --global credential.helper and if that is defined, we will set this value in the embedded Git. Do you have a better approach?

kittaakos pushed a commit that referenced this issue Dec 5, 2018
GH-3736: Use the system Git in electron.
5eef0f5 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes #3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Dec 5, 2018
GH-3736: Log the err when the initialization fails.
ea74751 
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Dec 5, 2018
Merged
kittaakos pushed a commit that referenced this issue Dec 6, 2018
GH-3736: Use the system Git in electron.
98161c0 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes #3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Dec 6, 2018
GH-3736: Use the system Git in electron.
7c32b73 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes #3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Dec 6, 2018
GH-3736: Use the system Git in electron.
b8ce225 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes #3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Dec 18, 2018
GH-3736: Use the system Git in electron.
5792e48 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes #3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Dec 18, 2018
@kittaakos
GH-3736: Use the system Git in electron.
29aa81b 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes #3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
eclipse-theiaGH-3736: Use the system Git in electron.
7f8038c 
If Git does not exisit on the `PATH`,
fall back to the embedded Git.

Closes eclipse-theia#3736.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
electron issues related to the electron target git issues related to git
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenefftinge @kittaakos