Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css/html monaco contributions vs VS Code extensions #3985

Closed
akosyakov opened this issue Jan 9, 2019 · 1 comment
Closed

css/html monaco contributions vs VS Code extensions #3985

akosyakov opened this issue Jan 9, 2019 · 1 comment
Assignees
@kittaakos
Labels
enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

akosyakov commented Jan 9, 2019 •
edited
Loading

VS Code has already built-in extensions for CSS and HTML language support. Our Monaco extension brings its own (not language declaration).

There are to options:

  • exclude CSS/HTML built-in VS Code extensions
  • or extract CSS/HTML Monaco contributions to a separate Theia extension and let decide end products what to use

// cc @svenefftinge
@akosyakov akosyakov added monaco issues related to monaco plug-in system issues related to the plug-in system labels Jan 9, 2019
@akosyakov akosyakov mentioned this issue Jan 9, 2019
Closed
@akosyakov
Copy link
Member Author

We've discussed it with @svenefftinge and decided to tackle it later. There is a value in using VS Code extensions because then diagnostics will be hooked up with our infrastructure. Right now they are not (because of inflexibility of monaco contributions) and a user cannot see them in the problem view and navigator.

@akosyakov akosyakov added the enhancement issues that are enhancements to current functionality - nice to haves label Jan 9, 2019
@akosyakov akosyakov self-assigned this Apr 7, 2020
@akosyakov akosyakov mentioned this issue Apr 7, 2020
Closed
@kittaakos kittaakos self-assigned this Jun 5, 2020
@akosyakov akosyakov removed their assignment Jun 5, 2020
kittaakos pushed a commit that referenced this issue Jun 5, 2020
GH-3985: Support for css/tml via VS Code extension
3bf7245 
Closes #3985

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @akosyakov