Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support VS Code when closure contexts #3986

Closed
akosyakov opened this issue Jan 9, 2019 · 2 comments · Fixed by #4076
Closed

support VS Code when closure contexts #3986

akosyakov opened this issue Jan 9, 2019 · 2 comments · Fixed by #4076
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings menus issues related to the menu plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings plug-in system issues related to the plug-in system labels Jan 9, 2019
@akosyakov akosyakov self-assigned this Jan 9, 2019
@akosyakov
Copy link
Member Author

For instance, issues from deploying debug-node VS Code extension:

root ERROR Unrecognized key 'F10' in 'F10'
root ERROR Cannot read property 'split' of undefined
root WARN Could not register keybinding:
  {"command":"extension.node-debug.startWithStopOnEntry","keybinding":"F10","context":"!inDebugMode && debugConfigurationType=='node'"}
Error: Unrecognized key 'F10' in 'F10'
root WARN Could not register keybinding:
  {"command":"extension.node-debug.startWithStopOnEntry","context":"!inDebugMode && debugConfigurationType=='node'"}
TypeError: Cannot read property 'split' of undefined

@akosyakov akosyakov added the menus issues related to the menu label Jan 13, 2019
@akosyakov
Copy link
Member Author

akosyakov commented Jan 15, 2019

Default contexts:

@akosyakov akosyakov changed the title [keybindings] support VS Code when closure contexts support VS Code when closure contexts Jan 15, 2019
akosyakov added a commit that referenced this issue Jan 15, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jan 15, 2019
18 tasks
akosyakov added a commit that referenced this issue Jan 15, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 16, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 17, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 17, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 17, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 18, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 23, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 23, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 24, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings menus issues related to the menu plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant