Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependencies to @theia/json in order to support VS Code JSON language features extensions #4217

Closed
akosyakov opened this issue Feb 1, 2019 · 5 comments
Labels
debug issues that related to debug functionality plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

Right now @theia/json Theia extension is always pulled via @theia/debug extension. We should remove such dependencies to make it possible to replace @theia/json extension by VS Code extension.

cc @thegecko

@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility debug issues that related to debug functionality labels Feb 1, 2019
@thegecko
Copy link
Member

thegecko commented Feb 1, 2019

RE:
#3657
#3663

Without this dependency, the debug configuration integration in the editor didn't work. Perhaps that UI should have a fallback when @theia/json is missing?

@akosyakov
Copy link
Member Author

Without this dependency, the debug configuration integration in the editor didn't work. Perhaps that UI should have a fallback when @theia/json is missing?

One can always include it explicitly in package.json. We can add a notification please install json extension?

@thegecko
Copy link
Member

thegecko commented Feb 1, 2019

In the case above it really wasn't clear that this dependency existed and as the UI is 'hidden' in the editor, it wasn't clear there was actually an issue.

IMO, I would prefer to see an error thrown if a required dependency is missing.

@paul-marechal
Copy link
Member

paul-marechal commented Nov 27, 2019

Would the debug configuration assistance work with the vscode json extension? IIUC we explicitly register schemas against our JsonSchemaStore component, would this be picked up by the vscode ext?

@akosyakov
Copy link
Member Author

Would the debug configuration assistance work with the vscode json extension? IIUC we explicitly register schemas against our JsonSchemaStore component, would this be picked up by the vscode ext?

We need to test and if not, we should make sure that it does.

vince-fugnitto pushed a commit that referenced this issue Jan 22, 2020
Fixes #4217

Removes dependencies to `@theia/json` from both the
`@theia/preferences` and `@theia/debug` extensions so that
we can use vscode builtin extensions instead.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
vince-fugnitto pushed a commit that referenced this issue Jan 22, 2020
Fixes #4217

Removes dependencies to `@theia/json` from both the
`@theia/preferences` and `@theia/debug` extensions so that
we can use vscode builtin extensions instead.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
vince-fugnitto pushed a commit that referenced this issue Jan 22, 2020
Fixes #4217

Removes dependencies to `@theia/json` from both the
`@theia/preferences` and `@theia/debug` extensions so that
we can use vscode builtin extensions instead.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Fixes eclipse-theia#4217

Removes dependencies to `@theia/json` from both the
`@theia/preferences` and `@theia/debug` extensions so that
we can use vscode builtin extensions instead.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
Fixes eclipse-theia#4217

Removes dependencies to `@theia/json` from both the
`@theia/preferences` and `@theia/debug` extensions so that
we can use vscode builtin extensions instead.

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants