-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependencies to @theia/json
in order to support VS Code JSON language features extensions
#4217
Comments
One can always include it explicitly in |
In the case above it really wasn't clear that this dependency existed and as the UI is 'hidden' in the editor, it wasn't clear there was actually an issue. IMO, I would prefer to see an error thrown if a required dependency is missing. |
Would the debug configuration assistance work with the vscode json extension? IIUC we explicitly register schemas against our |
We need to test and if not, we should make sure that it does. |
Fixes #4217 Removes dependencies to `@theia/json` from both the `@theia/preferences` and `@theia/debug` extensions so that we can use vscode builtin extensions instead. Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Fixes #4217 Removes dependencies to `@theia/json` from both the `@theia/preferences` and `@theia/debug` extensions so that we can use vscode builtin extensions instead. Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Fixes #4217 Removes dependencies to `@theia/json` from both the `@theia/preferences` and `@theia/debug` extensions so that we can use vscode builtin extensions instead. Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Fixes eclipse-theia#4217 Removes dependencies to `@theia/json` from both the `@theia/preferences` and `@theia/debug` extensions so that we can use vscode builtin extensions instead. Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Fixes eclipse-theia#4217 Removes dependencies to `@theia/json` from both the `@theia/preferences` and `@theia/debug` extensions so that we can use vscode builtin extensions instead. Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Right now
@theia/json
Theia extension is always pulled via@theia/debug
extension. We should remove such dependencies to make it possible to replace@theia/json
extension by VS Code extension.cc @thegecko
The text was updated successfully, but these errors were encountered: