Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download menu entry doesn't work on Firefox #4248

Closed
jankeromnes opened this issue Feb 4, 2019 · 4 comments · Fixed by #4762
Closed

Download menu entry doesn't work on Firefox #4248

jankeromnes opened this issue Feb 4, 2019 · 4 comments · Fixed by #4762
Labels
browser/firefox issues related to the firefox browser

Comments

@jankeromnes
Copy link
Member

Steps to reproduce:

  1. Open Theia in Theia (Gitpod.io)
  2. Right-click on any file in the file tree, then click the Download menu entry

Expected behavior:

  • The file gets downloaded

Actual behavior:

  • Nothing happens (reproduced in both Firefox and Chrome, and on both Linux and Mac)
@jankeromnes
Copy link
Member Author

Thanks @sylvestre for reporting this!

It's also worth nothing that no error is logged in the console, unfortunately.

@svenefftinge
Copy link
Contributor

svenefftinge commented Feb 4, 2019 •
edited
Loading

Just tried it and it worked.
(In Chrome) When I click on a file and select download. It immediately starts downloading (using chrome download), when on a folder it tars the folder and downloads that.
Do you have more information on how to reproduce it?

@jankeromnes
Copy link
Member Author

jankeromnes commented Feb 4, 2019 •
edited
Loading

Interesting. It didn't seem to do anything for me on Chrome at first (using localhost:3000 from Theia-in-Docker), but then suddenly it started working again (also it downloaded a project.tar first, instead of the file I requested, but that might have been my mistake).

Now it seems to work fine in Chrome, but I still can't get it to work in Firefox Nightly.

@svenefftinge svenefftinge changed the title Download menu entry doesn't work Download menu entry doesn't work on Firefox Feb 4, 2019
@akosyakov akosyakov added the browser/firefox issues related to the firefox browser label Feb 5, 2019
@geropl
Copy link
Contributor

geropl commented Mar 1, 2019

With bad internet I see quite a delay in Chrome between "Click Download" and the actual download starting (in Chrome UI).

Also, Download does not work in Firefox (no log output in either frontend nor backend).

@jankeromnes jankeromnes mentioned this issue Mar 26, 2019
Closed
@kittaakos kittaakos mentioned this issue Mar 28, 2019
Open
uniibu added a commit to uniibu/theia that referenced this issue Mar 29, 2019
@uniibu
parse content-disposition properly and fix firefox download
e7487a8 
This commit Fixes eclipse-theia#4754 and eclipse-theia#4248. It uses express' own attachement
method and parses the content-disposition reliably and decodes the
filename if possible. This also fixes the downloading on firefox by
appending the anchor link to the body before triggering the click event
and removes it after.

Signed-off-by: Uni Sayo <unibtc@gmail.com>
@uniibu uniibu mentioned this issue Mar 29, 2019
Merged
uniibu added a commit to uniibu/theia that referenced this issue Apr 9, 2019
@uniibu
parse content-disposition properly and fix firefox download
e9edbf0 
This commit Fixes eclipse-theia#4754 and eclipse-theia#4248. It uses express' own attachement
method and parses the content-disposition reliably and decodes the
filename if possible. This also fixes the downloading on firefox by
appending the anchor link to the body before triggering the click event
and removes it after.

Signed-off-by: Uni Sayo <unibtc@gmail.com>

use encodeUriComponent and decodeUriComponent

Signed-off-by: Uni Sayo <unibtc@gmail.com>
kittaakos pushed a commit that referenced this issue Apr 9, 2019
@uniibu @kittaakos
parse content-disposition properly and fix firefox download
ce2f145 
This commit Fixes #4754 and #4248. It uses express' own attachement
method and parses the content-disposition reliably and decodes the
filename if possible. This also fixes the downloading on firefox by
appending the anchor link to the body before triggering the click event
and removes it after.

Signed-off-by: Uni Sayo <unibtc@gmail.com>

use encodeUriComponent and decodeUriComponent

Signed-off-by: Uni Sayo <unibtc@gmail.com>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
@uniibu @kittaakos
parse content-disposition properly and fix firefox download
9f2b52d 
This commit Fixes eclipse-theia#4754 and eclipse-theia#4248. It uses express' own attachement
method and parses the content-disposition reliably and decodes the
filename if possible. This also fixes the downloading on firefox by
appending the anchor link to the body before triggering the click event
and removes it after.

Signed-off-by: Uni Sayo <unibtc@gmail.com>

use encodeUriComponent and decodeUriComponent

Signed-off-by: Uni Sayo <unibtc@gmail.com>

Signed-off-by: Doron Nahari doron.nahari@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser/firefox issues related to the firefox browser
Projects
None yet
Milestone
No milestone
4 participants
@svenefftinge @jankeromnes @akosyakov @geropl