Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui/ux] Do no expand the widgets on the side-bars for the context menu #4367

Closed
kittaakos opened this issue Feb 19, 2019 · 0 comments · Fixed by #6965
Closed

[ui/ux] Do no expand the widgets on the side-bars for the context menu #4367

kittaakos opened this issue Feb 19, 2019 · 0 comments · Fixed by #6965
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience

Comments

@kittaakos
Copy link
Contributor

This is a minor issue but still feels odd. When I want to close a widget on the sidebars with the context menu, first the widget expands, I close it, but the other widget remains expanded. See the attached screencast.

As a user, I would expect that the widget on the side-bar does not expand for the context menu. Or at least, I do not have to manually collapse the other widget.

screencast 2019-02-19 08-55-43
@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves ui/ux issues related to user interface / user experience labels Feb 19, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Feb 28, 2019
@vince-fugnitto vince-fugnitto mentioned this issue Sep 16, 2019
Closed
@Anasshahidd21 Anasshahidd21 mentioned this issue Jan 24, 2020
Merged
1 task
@Anasshahidd21 Anasshahidd21 mentioned this issue Mar 19, 2020
Closed
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 21, 2020
Core: Do no expand the widgets on the side-bars for the context menu
28b3349 
Fixes: eclipse-theia#4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 21, 2020
Core: Do no expand the widgets on the side-bars for the context menu
2155a89 
Fixes: eclipse-theia#4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 21, 2020
Core: Do no expand the widgets on the side-bars for the context menu
976a752 
Fixes: eclipse-theia#4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 26, 2020
Core: Do no expand the widgets on the side-bars for the context menu
f4f313a 
Fixes: eclipse-theia#4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
vince-fugnitto pushed a commit to Anasshahidd21/theia that referenced this issue Aug 31, 2020
@vince-fugnitto
Core: Do no expand the widgets on the side-bars for the context menu
d3434e9 
Fixes: eclipse-theia#4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
vince-fugnitto pushed a commit to Anasshahidd21/theia that referenced this issue Sep 3, 2020
@Anasshahidd21 @vince-fugnitto
Core: Do no expand the widgets on the side-bars for the context menu
9d45578 
Fixes: eclipse-theia#4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@mail.mcgill.ca>
vince-fugnitto pushed a commit that referenced this issue Sep 3, 2020
@Anasshahidd21 @vince-fugnitto
Core: Do no expand the widgets on the side-bars for the context menu
636b181 
Fixes: #4367

Before, right clicking on different menus would focus the menu item and open it, however this should not be the case. There was a dangling code in the handleContextMenu which causes this effect, as it was checking for the id when right clicked and looked up the ID for the menu-item and set the current title to the menu-item.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@mail.mcgill.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @akosyakov