Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement vscode env API #4446

Closed
akosyakov opened this issue Feb 28, 2019 · 6 comments
Closed

implement vscode env API #4446

akosyakov opened this issue Feb 28, 2019 · 6 comments
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Feb 28, 2019 •
edited
Loading

https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L5917-L5961

needed for #4224
@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Feb 28, 2019
@akosyakov akosyakov mentioned this issue Feb 28, 2019
Closed
@lmcbout lmcbout mentioned this issue Mar 1, 2019
Closed
benoitf added a commit that referenced this issue Apr 23, 2019
@benoitf
Add some missing entries in env object
c4d8117 
It's addressing partially #4446

Change-Id: I589ede711a18322b1afffe0479dace781f450045
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Apr 23, 2019
@benoitf
Add some missing entries in env object
85a3356 
It's addressing partially #4446

Change-Id: I589ede711a18322b1afffe0479dace781f450045
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf mentioned this issue Apr 23, 2019
Merged
1 task
benoitf added a commit that referenced this issue Apr 24, 2019
@benoitf
Add some missing entries in env object
404fe14 
It's addressing partially #4446

Change-Id: I589ede711a18322b1afffe0479dace781f450045
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Apr 24, 2019
@benoitf
Add some missing entries in env object
4a54abb 
It's addressing partially #4446

Change-Id: I589ede711a18322b1afffe0479dace781f450045
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
@benoitf
Add some missing entries in env object
3c80e60 
It's addressing partially eclipse-theia#4446

Change-Id: I589ede711a18322b1afffe0479dace781f450045
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

Signed-off-by: Doron Nahari doron.nahari@sap.com
@jeffmaury
Copy link

This is also required for the OpenShift Connector from marketplace which uses the clipboard API

@akosyakov
Copy link
Member Author

@jeffmaury to track clipboard api see this issue: #5519

@akosyakov
Copy link
Member Author

linking #6039

@akosyakov
Copy link
Member Author

remoteName and uiKind are missing. For the former we can stub with undefined, since we are not capable to run VS Code remote extensions yet. And for the latter with we could actually implement running VS Code extensions in the web worker or stub it with UIKind.Desktop for now.

@DanTup
Copy link
Contributor

DanTup commented May 19, 2020

since we are not capable to run VS Code remote extensions yet

My understanding is that remoteName is set when there is a remote extension host (eg. the extension host is on a different logical machine to the editors UI). For example remoteName comes through as vsonline for VS Codespaces in any standard session. I would've expected GitPod to always have this value set to something.

@tsmaeder
Copy link
Contributor

env namespace is fully implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeffmaury @DanTup @akosyakov @tsmaeder