Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no error when run VS code extensionthat use extensionDependencies that doesn't loaded #4504

Closed
i501378 opened this issue Mar 7, 2019 · 0 comments · Fixed by #5379
Closed

There is no error when run VS code extensionthat use extensionDependencies that doesn't loaded #4504

i501378 opened this issue Mar 7, 2019 · 0 comments · Fixed by #5379
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@i501378
Copy link
Contributor

i501378 commented Mar 7, 2019

We use APIs from VS code extension1 at VS code extension2.
We add VS code extension1 as extensionDependencies at VS code extension2 package.json.
We run VS code extension2 without loading at the plugins VS code extension1 and we don't get any error.

output when we load VS code extension1
image

output when we don't load VS code extension1
image
@i501378 i501378 changed the title There is no error when extensionDependencies doesn't loaded There is no error when run VS code extensionthat use extensionDependencies that doesn't loaded Mar 7, 2019
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Mar 8, 2019
@tsmaeder tsmaeder mentioned this issue May 21, 2019
Closed
26 tasks
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 6, 2019
@JPinkney
Added extensionDependency automatically downloading. Fixes: eclipse-t…
e0aedde 
…heia#4504

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@JPinkney JPinkney mentioned this issue Jun 6, 2019
Merged
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 10, 2019
@JPinkney
Added extensionDependency automatically downloading. Fixes: eclipse-t…
e9b6699 
…heia#4504

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@tsmaeder tsmaeder mentioned this issue Jun 11, 2019
Closed
27 tasks
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 18, 2019
@JPinkney
Added extensionDependency automatically downloading. Fixes: eclipse-t…
0b6c8d9 
…heia#4504

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 18, 2019
@JPinkney
Added extensionDependency automatically downloading. Fixes: eclipse-t…
1acc628 
…heia#4504

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@tsmaeder tsmaeder mentioned this issue Jul 3, 2019
Closed
19 tasks
JPinkney added a commit to JPinkney/theia that referenced this issue Aug 15, 2019
@JPinkney
Added extensionDependency automatically downloading. Fixes: eclipse-t…
0f28b77 
…heia#4504

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
akosyakov pushed a commit that referenced this issue Aug 18, 2019
@JPinkney @akosyakov
Added extensionDependency automatically downloading. Fixes: #4504
2d4c845 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin] Added extensionDependency automatically downloading. Fixes: #4504 JPinkney/theia
2 participants
@akosyakov @i501378