Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] Add PHP grammar contributions #4582

Closed
vrubezhny opened this issue Mar 15, 2019 · 4 comments
Closed

[plugin] Add PHP grammar contributions #4582

vrubezhny opened this issue Mar 15, 2019 · 4 comments
Labels
php issues related to the php language textmate issues related to the textmate grammars vscode issues related to VSCode compatibility

Comments

@vrubezhny
Copy link
Contributor

vrubezhny commented Mar 15, 2019

PHP grammar contributions are must be added to Theia for PHP Language

The CQ [1], [2] needs to be resolved before merging a fix for this issue
Need to remove the similar contribution from PHP extension [3]

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19282
[2] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19509
[3] https://github.com/theia-ide/theia-php-extension

Reference issues:
eclipse-che/che#12796
eclipse-che/che#12797

@akosyakov
Copy link
Member

I would really recommend to consider using builtin vscode extensions instead of textmate-grammars extension. They contain snippets, some default language specific editor settings and so on.

@akosyakov akosyakov added php issues related to the php language textmate issues related to the textmate grammars vscode issues related to VSCode compatibility labels Mar 15, 2019
@vrubezhny
Copy link
Contributor Author

I would really recommend to consider using builtin vscode extensions instead of textmate-grammars extension. They contain snippets, some default language specific editor settings and so on.

@akosyakov The grammars & snippets referenced in CQ (and those I'm going to propose for inclusion to Theia) are taken directly from VS Code: https://github.com/Microsoft/vscode/tree/master/extensions/php - are they what do you mean?

@akosyakov
Copy link
Member

textmate-grammars Theia extension does not have anything except textmate grammars as far as i know. VS Code built-in extensions are more than that.

vrubezhny added a commit to vrubezhny/theia-php-extension that referenced this issue Apr 3, 2019
PHP grammar contributions are added to Theia for PHP Language in [1],
as such they must be removed from theia-php-extension.

[1] eclipse-theia/theia#4582

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny
Copy link
Contributor Author

Yet another CQ is opened for the issue: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19509

vrubezhny added a commit that referenced this issue Apr 15, 2019
The CQ [1] needs to be resolved before merging this commit
Need to remove the similar contribution from PHP extension[2]

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19282
[2] https://github.com/theia-ide/theia-php-extension

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
akosyakov pushed a commit to theia-ide/theia-php-extension that referenced this issue Apr 15, 2019
PHP grammar contributions are added to Theia for PHP Language in [1],
as such they must be removed from theia-php-extension.

[1] eclipse-theia/theia#4582

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
The CQ [1] needs to be resolved before merging this commit
Need to remove the similar contribution from PHP extension[2]

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19282
[2] https://github.com/theia-ide/theia-php-extension

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>

Signed-off-by: Doron Nahari doron.nahari@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php issues related to the php language textmate issues related to the textmate grammars vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants