-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin] Add PHP grammar contributions #4582
Comments
I would really recommend to consider using builtin vscode extensions instead of textmate-grammars extension. They contain snippets, some default language specific editor settings and so on. |
@akosyakov The grammars & snippets referenced in CQ (and those I'm going to propose for inclusion to Theia) are taken directly from VS Code: https://github.com/Microsoft/vscode/tree/master/extensions/php - are they what do you mean? |
textmate-grammars Theia extension does not have anything except textmate grammars as far as i know. VS Code built-in extensions are more than that. |
PHP grammar contributions are added to Theia for PHP Language in [1], as such they must be removed from theia-php-extension. [1] eclipse-theia/theia#4582 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Yet another CQ is opened for the issue: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19509 |
The CQ [1] needs to be resolved before merging this commit Need to remove the similar contribution from PHP extension[2] [1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19282 [2] https://github.com/theia-ide/theia-php-extension Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
PHP grammar contributions are added to Theia for PHP Language in [1], as such they must be removed from theia-php-extension. [1] eclipse-theia/theia#4582 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
The CQ [1] needs to be resolved before merging this commit Need to remove the similar contribution from PHP extension[2] [1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19282 [2] https://github.com/theia-ide/theia-php-extension Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com> Signed-off-by: Doron Nahari doron.nahari@sap.com
PHP grammar contributions are must be added to Theia for PHP Language
The CQ [1], [2] needs to be resolved before merging a fix for this issue
Need to remove the similar contribution from PHP extension [3]
[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19282
[2] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19509
[3] https://github.com/theia-ide/theia-php-extension
Reference issues:
eclipse-che/che#12796
eclipse-che/che#12797
The text was updated successfully, but these errors were encountered: