Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files.associations does not work #4716

Closed
akosyakov opened this issue Mar 26, 2019 · 8 comments
Closed

files.associations does not work #4716

akosyakov opened this issue Mar 26, 2019 · 8 comments
Labels
bug bugs found in the application editor issues related to the editor filesystem issues related to the filesystem

Comments

@akosyakov
Copy link
Member

    "files.associations": {
        "*.go": "typescript"
    }

An editor for *.go languages should prefer typescript language, it does not.

@akosyakov akosyakov added bug bugs found in the application filesystem issues related to the filesystem editor issues related to the editor labels Mar 26, 2019
@jonnyhork
Copy link

Hey @akosyakov, I've been sort of following along with this issue but I was hoping you could clarify some thing for me. If I understand the current state, it seems that the files.associations setting was added by #4713 but it is not yet functional after #4721? I'm curious because don't see the files.associations option in setting at all when I spin up the lates version of Theia 0.5.0-next.9043bc1d.
Do you have any idea when this implementation might be functional?

Thanks for the help on this, I appreciate it!

@akosyakov
Copy link
Member Author

akosyakov commented Mar 28, 2019

It was not introduced yet, it was stubbed to make VS Code extensions to load. An implementation is tracked in #4581.

Do you have any idea when this implementation might be functional?

@tolusha could you help to answer please

@tolusha tolusha changed the title files.associations does not wokr files.associations does not work Mar 28, 2019
@tolusha
Copy link
Contributor

tolusha commented Mar 28, 2019

@jonnyhork
As @akosyakov mentioned an implementation is tracked in #4581
My initial plan was to fix extension loading #4721
For the time being I postponed the issue #4581

@jonnyhork
Copy link

jonnyhork commented Mar 28, 2019

Ok thanks @tolusha , I'll keep an eye on #4581.

For the time being I postponed the issue #4581

Does this mean there is currently no plan to continue work on the implementation at the moment?
I'm asking just so I can have a better understanding of the timeline for custom file associations and plan accordingly.

@tsmaeder
Copy link
Contributor

We'll get back to it in our next sprint (starting week after next)

@jonnyhork
Copy link

jonnyhork commented Apr 15, 2019

@tsmaeder Hi, I just wanted to check in about this issue. I see that file.associations was added to this sprint but I am hoping you could speak to and estimated time for implementation. This would help me decide whether to use a workaround solution depending on the timeline. Thanks again for your help!

@tolusha
Copy link
Contributor

tolusha commented Apr 16, 2019

@jonnyhork
I would suggest using workaround for now.

@akosyakov
Copy link
Member Author

fixed by #4973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application editor issues related to the editor filesystem issues related to the filesystem
Projects
None yet
Development

No branches or pull requests

4 participants