Implement files.associations properties #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Apr 24, 2019
akosyakov
reviewed
Apr 25, 2019
akosyakov
reviewed
Apr 25, 2019
akosyakov
reviewed
Apr 25, 2019
akosyakov
reviewed
Apr 25, 2019
tolusha
force-pushed
the
ab/files.associations
branch
from
574a1ea to
fbc5730
Compare
akosyakov
reviewed
Apr 26, 2019
akosyakov
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
it looks good, please update 2018 -> 2019
Please also file follow-up issues:
- for editors with auto-detected languages it should be recomputed on mime associations change
- label provider should take into account a language matching to the given URI to create an icon, not only a file extension like right now (i.e. UI should reflect mime associations, e.g. explorer should show proper a matching language icon)
tolusha
force-pushed
the
ab/files.associations
branch
from
fbc5730 to
6d6376f
Compare
tolusha
force-pushed
the
ab/files.associations
branch
from
96f76c1 to
e385dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do
Allows to set
files.associationsproperties in the preferences.https://code.visualstudio.com/docs/languages/identifiers
Reference issue
#4581