Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Task command and quick task palette should behave in the same way #4768

Closed
akosyakov opened this issue Apr 1, 2019 · 0 comments · Fixed by #4920
Closed

Run Task command and quick task palette should behave in the same way #4768

akosyakov opened this issue Apr 1, 2019 · 0 comments · Fixed by #4920
Labels
bug bugs found in the application tasks issues related to the task system ui/ux issues related to user interface / user experience

Comments

@akosyakov
Copy link
Member

In VS Code they behave the same, in Theia they don't. For instance one cannot configure tasks from the quick task in Theia.

Run Task in VS Code:
Screen Shot 2019-03-27 at 14 32 38

Quick task in VS Code:
Screen Shot 2019-03-27 at 14 32 55

Run Task in Theia:
Screen Shot 2019-04-01 at 12 14 26

Quick task in Theia:
Screen Shot 2019-04-01 at 12 14 15

cc @elaihau @RomanNikitenko
@akosyakov akosyakov added bug bugs found in the application tasks issues related to the task system ui/ux issues related to user interface / user experience labels Apr 1, 2019
@akosyakov akosyakov changed the title Run Task command and quick task panel should be the same widget Run Task command and quick task palette should behave in the same way Apr 1, 2019
@akosyakov akosyakov mentioned this issue Apr 1, 2019
Merged
vince-fugnitto added a commit that referenced this issue Apr 15, 2019
@vince-fugnitto
Update the prefix quick-open service to use actionProviders
d33e7d8 
Fixes #4768

- updated the `prefix-quick-open-service` to pass the `actionProviders` if available.
- fixes an issue for the `tasks` prefix quick-open which did not have the configuration action available.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Apr 15, 2019
Merged
vince-fugnitto added a commit that referenced this issue Apr 15, 2019
@vince-fugnitto
Update the prefix quick-open service to use actionProviders
36ae53d 
Fixes #4768

- updated the `prefix-quick-open-service` to pass the `actionProviders` if available.
- fixes an issue for the `tasks` prefix quick-open which did not have the configuration action available.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Apr 16, 2019
@vince-fugnitto
Update the prefix quick-open service to use actionProviders
7ee91ad 
Fixes #4768

- updated the `prefix-quick-open-service` to pass the `actionProviders` if available.
- fixes an issue for the `tasks` prefix quick-open which did not have the configuration action available.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
@vince-fugnitto
Update the prefix quick-open service to use actionProviders
36df6d0 
Fixes eclipse-theia#4768

- updated the `prefix-quick-open-service` to pass the `actionProviders` if available.
- fixes an issue for the `tasks` prefix quick-open which did not have the configuration action available.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Doron Nahari doron.nahari@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application tasks issues related to the task system ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tasks] update the prefix quick-open service to use actionProviders eclipse-theia/theia
1 participant
@akosyakov