-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load built-in vscode plugins to Theia: grunt, gulp, jake #4814
Comments
It is possible to have tasks with the same type, so we need to differentiate them. Using the handle available with the task to create a unique provider. Allow to have following plugins within the same workspace: - grunt - gulp - jake Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com>
It is possible to have tasks with the same type, so we need to differentiate them. Using the handle available with the task to create a unique provider. This allow to have following plugins within the same workspace: - grunt - gulp - jake Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com>
Jake is using the old API to computeTask(). Because of that, I need to implement the deprecated Task constructor to handle Jake. In the current solution, I implemented solution 1, so we can support JAKE until vscode modify the Jake plugin For solution 2, we need to modify: OLD: NEW: For testing purpose, you need to add in the package.json the following packages. (Either in devDependencies or dependencies) |
If this API is still into https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts then we have to support it regardless whether it is deprecated or not. Just mark them as deprecated as well. |
it is still there so yes (BTW PR is doing that) |
This is what I did, I put deprecated with the constructor (Same as in vscode) |
It is possible to have tasks with the same type, so we need to differentiate them. Using the handle available with the task to create a unique provider. This allow to have following plugins within the same workspace: - grunt - gulp - jake Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com>
It is possible to have tasks with the same type, so we need to differentiate them. Using the handle available with the task to create a unique provider. This allow to have following plugins within the same workspace: - grunt - gulp - jake Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com>
It is possible to have tasks with the same type, so we need to differentiate them. Using the handle available with the task to create a unique provider. This allow to have following plugins within the same workspace: - grunt - gulp - jake Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com>
It is possible to have tasks with the same type, so we need to differentiate them. Using the handle available with the task to create a unique provider. This allow to have following plugins within the same workspace: - grunt - gulp - jake Signed-off-by: Jacques Bouthillier <jacques.bouthillier@ericsson.com> Signed-off-by: Doron Nahari doron.nahari@sap.com
Description
Capability to load built-in vscode plugins to Theia
Looking at grunt, gulp and jake
Reproduction Steps
Put the jake, grunt and gulp vscode built-in plugins into the theia/plugins folder
unzip/untar the test project attached
npm install // to build the node_modules
Start theia and load the test project into the browser
Note:
1- Load the test program (Note, just to test that we can extract the task as "GULP, GRUNT, JAKE, NPM"
2- For Jake, still under investigation
OS and Theia version:
Ubuntu 16.04
Theia 0.5.0
Diagnostics:
test.tar.gz
The text was updated successfully, but these errors were encountered: