Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron] Adjust the customized environment.electron#is implementation #4875

Closed
kittaakos opened this issue Apr 11, 2019 · 0 comments · Fixed by #7386
Closed

[electron] Adjust the customized environment.electron#is implementation #4875

kittaakos opened this issue Apr 11, 2019 · 0 comments · Fixed by #7386
Labels
electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Apr 11, 2019 •
edited
Loading

We had to implement a customized electron#is function to be able to recognize if any of the Theia backend workers were started from electron. See #3254.

The cluster mode has been removed, so in theory, we can remove this customization.

Related: #4288
@kittaakos kittaakos added the electron issues related to the electron target label Apr 11, 2019
kittaakos pushed a commit that referenced this issue Mar 18, 2020
GH-7358: Corrected how we spawn the BE in electron
dd250c1 
A process, forked from the electron main, does not contain the
`process.versions.electron` entry, which causes native loading issues.
Instead of forking, we `spawn` a process and set the IPC channels.

Closes #7358
Closes #4288
Closes #4875

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Mar 18, 2020
Closed
1 task
kittaakos pushed a commit that referenced this issue Mar 18, 2020
GH-7358: Corrected how we spawn the BE in electron
e12bf18 
A process, forked from the electron main, does not contain the
`process.versions.electron` entry, which causes native loading issues.
Instead of forking, we `spawn` a process and set the IPC channels.

Closes #7358
Closes #4288
Closes #4875

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@paul-marechal paul-marechal mentioned this issue Mar 20, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron issues related to the electron target
Projects
None yet
Milestone
No milestone
1 participant
@kittaakos