Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin-API] Improve window.createInput() #5109

Closed
vinokurig opened this issue May 10, 2019 · 3 comments
Closed

[Plugin-API] Improve window.createInput() #5109

vinokurig opened this issue May 10, 2019 · 3 comments

Comments

@vinokurig
Copy link
Contributor

Description

window.createInput() introduced in #5107 have only the base functionality, reused from QuickOpenExtImpl:

  • value (Current input value)
  • placeholder (Optional placeholder in the filter text)
  • password (If the input value should be hidden. Defaults to false)
  • prompt (An optional prompt text providing some ask or explanation to the user)
  • onDidChangeValue (An event signaling when the value has changed)
  • onDidAccept (An event signaling when the user indicated acceptance of the input value)
  • validationMessage (An optional validation message indicating a problem with the current input value)
  • show()

Functionality that is not supported by QuickOpenExtImpl but declared in InputBox:

  • buttons (Buttons for actions in the UI)
  • onDidTriggerButton (An event signaling when a button was triggered)
  • step / totalSteps (An optional current / total step count)
  • busy (If the UI should show a progress indicator)
  • enabled (If the UI should allow for user input)
@JPinkney JPinkney mentioned this issue May 11, 2019
Closed
@JPinkney
Copy link
Contributor

Hi, I’ve already started work on both #5107 and #5109 as well as implementing the QuickInput API as part of #5084. It should be done in a week or two. I just wanted to let you know so we don’t duplicate work (if you were going to work on this issue).

@JPinkney JPinkney mentioned this issue May 19, 2019
Merged
JPinkney added a commit to JPinkney/theia that referenced this issue Jun 4, 2019
@JPinkney
Improved QuickInput/InputBox API's. Partially fixes: eclipse-theia#5109
3c29097 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@tetchel tetchel mentioned this issue Jun 17, 2019
Closed
@ira-gordin-sap
Copy link

Hi, could you please share some estimation for this item?

@JPinkney
Copy link
Contributor

Everything that can be done currently is in a PR (#5187) that i'm fixing up today

JPinkney added a commit to JPinkney/theia that referenced this issue Jun 21, 2019
@JPinkney
Improved QuickInput/InputBox API's. Partially fixes: eclipse-theia#5109
ae9ad2e 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney added a commit to JPinkney/theia that referenced this issue Jul 23, 2019
@JPinkney
Improved QuickInput/InputBox API's. Partially fixes: eclipse-theia#5109
046bc1c 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney added a commit to JPinkney/theia that referenced this issue Jul 26, 2019
@JPinkney
Improve QuickInput/InputBox API's. Partially fixes: eclipse-theia#5109
f4b062f 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney added a commit to JPinkney/theia that referenced this issue Jul 26, 2019
@JPinkney
Improve QuickInput/InputBox API's. Partially fixes: eclipse-theia#5109
1f2da76 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
vinokurig pushed a commit that referenced this issue Aug 5, 2019
@JPinkney @vinokurig
Improve QuickInput/InputBox API's. Partially fixes: #5109
b80d58d 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
vinokurig pushed a commit that referenced this issue Aug 6, 2019
@JPinkney @vinokurig
Improve QuickInput/InputBox API's. Partially fixes: #5109
f280acb 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
vinokurig pushed a commit to JPinkney/theia that referenced this issue Aug 6, 2019
@JPinkney @vinokurig
Improve QuickInput/InputBox API's. Partially fixes: eclipse-theia#5109
412f832 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
vinokurig pushed a commit that referenced this issue Aug 8, 2019
@JPinkney @vinokurig
Improve QuickInput/InputBox API's. Partially fixes: #5109
96c28a3 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
benoitf pushed a commit that referenced this issue Aug 8, 2019
@JPinkney @benoitf
Improve QuickInput/InputBox API's. Partially fixes: #5109
17be912 
Co-authored-by: Josh Pinkney <joshpinkney@gmail.com>
Co-authored-by: Igor Vinokur <ivinokur@redhat.com>

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vinokurig @JPinkney @ira-gordin-sap