Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hosted-plugin] Make the Plugin folder notification user friendly #5693

Closed
kittaakos opened this issue Jul 11, 2019 · 0 comments · Fixed by #5731
Closed

[hosted-plugin] Make the Plugin folder notification user friendly #5693

kittaakos opened this issue Jul 11, 2019 · 0 comments · Fixed by #5731
Labels
enhancement issues that are enhancements to current functionality - nice to haves good first issue good first issues for new contributors plug-in system issues related to the plug-in system

Comments

@kittaakos
Copy link
Contributor

When I start a hosted instance on Windows, I can see the following as a notification.

Screen Shot 2019-07-11 at 10 36 02

file:///c%3A/ is not a thing I would like to see as a Windows user. It is alien.

TODO:

  • Use the path instead of the URI, OR
  • Decode the URI.
@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves good first issue good first issues for new contributors plug-in system issues related to the plug-in system labels Jul 11, 2019
This was referenced Jul 16, 2019
Closed
Merged
chattarajoy added a commit to chattarajoy/theia that referenced this issue Jul 18, 2019
@chattarajoy
Fixes eclipse-theia#5693 Show Path in PluginFolder Notification
f47c6c1 
Signed-off-by: Joy Lal Chattaraj <Joylal4896@gmail.com>
kittaakos pushed a commit that referenced this issue Jul 18, 2019
@chattarajoy @kittaakos
Fixes #5693 Show Path in PluginFolder Notification
d4a15ad 
Signed-off-by: Joy Lal Chattaraj <Joylal4896@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves good first issue good first issues for new contributors plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
1 participant
@kittaakos