-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring of a task #5747
Comments
This was referenced Jul 18, 2019
elaihau
pushed a commit
that referenced
this issue
Jul 23, 2019
- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Jul 23, 2019
- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Jul 24, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Jul 24, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Jul 27, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - allow users to override any task properties other than the ones used in the task definition. - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Jul 28, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - allow users to override any task properties other than the ones used in the task definition. - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Jul 28, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - allow users to override any task properties other than `type`, and those that are used to define the in its task definition. - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Aug 1, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - allow users to override any task properties other than `type`, and those that are used to define the in its task definition. - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau
pushed a commit
that referenced
this issue
Aug 1, 2019
- edit the right task.json when clicking "configure task" in multi-root workspace (fixed #4919) - in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - allow users to override any task properties other than `type`, and those that are used to define the in its task definition. - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. - The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
A task is not displayed in
configured tasks
section after configuring.Is it correct behavior?
Reproduction Steps
1.
Terminal
=>Run Task
menu, selectnpm:build
and clickcog
icon (configure task action)2. You can see that the configuration is copied to
tasks.json
file and you can edit it3. Go again to
Terminal
=>Run Task
menu4. You can see that the task still in
detected tasks
sectionPlease see the video: https://youtu.be/C5bp8mdSFgM
Diagnostics:
I investigated a little source code and found that:
detected
tasknpm:build
, it is copied totasks.json
filetasks.json
file the configuration goes tocustomizations
, not toconfiguredTasksArray
Run Task
menuconfigured
tasks are taken, notcustomizations
.customizations
are used at running ofdetected
taskAs result,
npm:build
task is not displayed inconfigured tasks
section.So, what's the correct new behavior?
configured tasks
section display only configurations fromtasks.json
which don't have 'parent'detected
task?detected
andcustomization
configs. I mean use case like described here: Recently used tasks section should respect configured tasks #5067tasks.json
applied for a configuration which have 'parent'detected
task?Thanks in advance!
The text was updated successfully, but these errors were encountered: