[debug]"add debug configuration" gives wrong suggestion in the first time

[kpge]

Description

the first time click 'Add Configuration' gives the wrong suggestion regardless the launch.json file is existed.

Reproduction Steps

• close the launch.json file
• refresh the browser
• click Add Configuration in the debug widget

OS and Theia version:
theia:5c298024b5f5d705e6a53eaeb4660083350be91b
Diagnostics:

[akosyakov]

in the example app? or you install some vscode extensions?

[kpge]

in the example app? or you install some vscode extensions?

I start theia in example app

[kpge]

It looks like that json language server had not been ready when the command editor.action.triggerSuggest is executed

[akosyakov]

@kpge Do you want to investigate?

[akosyakov]

It should be started whenever a workspace has json file: https://github.com/theia-ide/theia/blob/2befdf4cbebbbddb9719e0b88a578fba13f61808/packages/json/src/browser/json-client-contribution.ts#L82-L87

Maybe it just takes time or there is a bug and globs are never match.

[kpge]

It should be started whenever a workspace has json file:

https://github.com/theia-ide/theia/blob/2befdf4cbebbbddb9719e0b88a578fba13f61808/packages/json/src/browser/json-client-contribution.ts#L82-L87

Maybe it just takes time or there is a bug and globs are never match.

It won't be called until a json file is opened, I think there's a bug here.

[akosyakov]

It won't be called until a json file is opened, I think there's a bug here.

It should be fine, some language servers are started only when file is opened.

I've noticed that you don't have syntax coloring. It means that is not an issues with a language server, but a language itself. An editor is opened before the language is registered and auto detects a language as plain text.

We fixed something like that for the plugin system: #5754 I think we need to generalize it for textmate grammar contributions.

[kpge]

The registerTextmateLanguage in JsonGrammarContribution will be called when the workspace is loaded, and when the json file is colored, it still shows the wrong suggestion.

[akosyakov]

@kpge Could you try with #6145 please?

[kpge]

@kpge Could you try with #6145 please?

no，It still gives the same wrong suggestion.

[vince-fugnitto]

@kpge I've tried recently and it works correctly for me, can you confirm?

[kpge]

@vince-fugnitto No, it still gives the wrong suggestion. Are you cloesed all the json file and refresh the page?

[vince-fugnitto]

@vince-fugnitto No, it still gives the wrong suggestion. Are you cloesed all the json file and refresh the page?

Sorry for the late reply, I must have missed the notification.
I have retried recently and still cannot reproduce the issue. If you still experience the issue can you please provide the list of steps to reproduce and list of extensions included?

[kpge]

@vince-fugnitto sorry for the late reply too
I pulled the code and checked this issue, and found that this bug had been fixed, thanks

[vince-fugnitto]

@vince-fugnitto sorry for the late reply too
I pulled the code and checked this issue, and found that this bug had been fixed!

Great, and no worries! 😃