Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the "file has been changed" dialog #5831

Open
AlexTugarev opened this issue Jul 31, 2019 · 6 comments
Open

Improve the "file has been changed" dialog #5831

AlexTugarev opened this issue Jul 31, 2019 · 6 comments
Labels
filesystem issues related to the filesystem help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience

Comments

@AlexTugarev
Copy link
Contributor

AlexTugarev commented Jul 31, 2019

Screen Shot 2019-07-31 at 13 08 48

  • the title is too long
  • the buttons should be something like Replace | Keep | Cancel
@AlexTugarev AlexTugarev added editor issues related to the editor ui/ux issues related to user interface / user experience labels Jul 31, 2019
@akosyakov akosyakov added filesystem issues related to the filesystem and removed editor issues related to the editor labels Jul 31, 2019
@akosyakov akosyakov changed the title [editor] Improve the "file has been changed" dialog Improve the "file has been changed" dialog Jul 31, 2019
@AlexTugarev
Copy link
Contributor Author

Thanks for the pointer @akosyakov!

Looking at what happened behind the scene, I think this also unveils a flaw with the integration of preferences in the plugin system. I get this message every time I'm switching the Python interpreter.

@akosyakov
Copy link
Member

@AlexTugarev Can you file an issue for it with steps to reproduce?

@vince-fugnitto
Copy link
Member

@kaiyue0329 I think this might be an interesting issue to take a look at, if you require any assistance (ex: how to reproduce) please let me know :)

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jan 10, 2020
@kaiyue0329
Copy link
Contributor

@vince-fugnitto I re-formatted the file name so that only the only the last part of the path (ex. 'settings.json') is displayed in the title. I was wondering if you can help me to reproduce the issue. Thanks.

@vince-fugnitto
Copy link
Member

@vince-fugnitto I re-formatted the file name so that only the only the last part of the path (ex. 'settings.json') is displayed in the title. I was wondering if you can help me to reproduce the issue. Thanks.

Unfortunately, I was unable to successfully reproduce the issue:

  • I turned the preference auto safe off
  • I made unsaved changes to a file
  • I made updates on the filesystem for the same file
  • I attempted to save the file, and while the save failed the dialog did not appear

Perhaps @AlexTugarev can help steps to reproduce.

@vince-fugnitto
Copy link
Member

I managed to reproduce it following the same issue as #6786
Basically the idea is to add themes as plugins into the application, trigger the color theme command, and quickly change themes and eventually the problem occurs:

image

Steps:

  1. create a plugins folder at the root of the application (mkdir plugins)
  2. add themes to the plugins folder (copy them as .vsix files):
  3. trigger the command color theme ctrlcmd+shift+p and Preferences: Color Theme
  4. toggle between the available themes (keeping the quick-open open), and eventually the dialog will pop up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

4 participants