Improve the 'file has changed' dialog #6873
Conversation
There was a problem hiding this comment.
The dialog now correctly displays the shorter title with only the filename:
Do you think it'd be good to display the full path using labelProvider.getLongName within the actual body of the dialog? This will avoid confusion for users who may have multiple files with the same name in their workspace with different paths, and help them quickly identify the file in question.
Something like:
msg: `Do you want to overwrite the changes made to "${labelProvider.getLongName(new URI(file.uri)}" on the file system?`,
|
The path would remove ambiguity. Can you add or display it as a tooltip over the dialog ? |
I think a tooltip would be too complicated and un-intuitive for a pop up dialog. |
|
@kaiyue0329 do you mind squashing your commits into a single commit, preserving the detailed commit message? |
- Use LabelProvider.getName(uri) to get a systemwide human readable representation of a simple file name. - Use LabelProvider.getLongName(uri) to get a systemwide human readable representation of a full path. Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
There was a problem hiding this comment.
It looks fine to me 👍
I won't close #5831 since it describes adding new buttons, but in my opinion they aren't explicitly useful.
|
Looking at the picture, can you make the window smaller by putting the message data in two lines , i think it would be better since the file path is very long |
@lmcbout not sure the change should be applied here. Would it not be better to have a Example, I created the following dialog: 
I think this is a separate enhancement that can be tracked in an issue. |
|
Very very long text could be handle on a separate issue, It is OK for me |
|
@kaiyue0329 I think you might have pushed changes unrelated to this pull request instead of opening a new one. |
|
@vince-fugnitto I will revert the unrelated changes and create a new branch. |
Issue: #5831
What it does
How to test
Reminder for reviewers