Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pluginExt] npm scripts showed when config.npm.enableScriptExplorer is false after npm extension installed #5853

Closed
kpge opened this issue Aug 5, 2019 · 2 comments · Fixed by #5855
Closed

[pluginExt] npm scripts showed when config.npm.enableScriptExplorer is false after npm extension installed #5853

kpge opened this issue Aug 5, 2019 · 2 comments · Fixed by #5855
Assignees
@akosyakov
Labels
bug bugs found in the application shell issues related to the core shell vscode issues related to VSCode compatibility

Comments

@kpge
Copy link
Contributor

kpge commented Aug 5, 2019

Description

when I installed npm extension from vscode, ther npm scripts eabled in the explorer widget, no matter what the value of config.npm.enableScriptExplorer is .

image
but the view should be enabled when config.npm.enableScriptExplorer is true
image

Reproduction Steps

  • install the npm version to theia plugins dir.
  • compile the latest theia, and start theia example app.
    OS and Theia version:
    theia version: the latest version (b40a8d5)
    Diagnostics:
@akosyakov akosyakov added bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility labels Aug 5, 2019
@akosyakov
Copy link
Member

@kpge Would you like to investigate?

cc @elaihau

@akosyakov akosyakov added help wanted issues meant to be picked up, require help and removed help wanted issues meant to be picked up, require help labels Aug 5, 2019
@akosyakov akosyakov self-assigned this Aug 5, 2019
@akosyakov akosyakov added shell issues related to the core shell and removed tasks issues related to the task system labels Aug 5, 2019
@akosyakov
Copy link
Member

It is the view container issue. @AlexTugarev was mentioning that when closure is ignored. I will do a PR promptly.

akosyakov added a commit that referenced this issue Aug 5, 2019
@akosyakov
[vscode] fix #5853: support when closure for views
ba89555 
- a view visibility should be auto toggled based on `when` view closure
- if a user explicitly hides a view, then auto toggling should be disabled
- and it should be enabled again when a user explicitly unhides the view

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Aug 5, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Aug 6, 2019
@akosyakov
[vscode] fix #5853: support when closure for views
17236ad 
- a view visibility should be auto toggled based on `when` view closure
- if a user explicitly hides a view, then auto toggling should be disabled
- and it should be enabled again when a user explicitly unhides the view

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 7, 2019
@akosyakov
[vscode] fix #5853: support when closure for views
15b94f3 
- a view visibility should be auto toggled based on `when` view closure
- if a user explicitly hides a view, then auto toggling should be disabled
- and it should be enabled again when a user explicitly unhides the view

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application shell issues related to the core shell vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] support when closure for views eclipse-theia/theia
2 participants
@akosyakov @kpge