Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect displaying of configured task after refreshing page #5878

Closed
RomanNikitenko opened this issue Aug 7, 2019 · 9 comments · Fixed by #5975
Closed

Incorrect displaying of configured task after refreshing page #5878

RomanNikitenko opened this issue Aug 7, 2019 · 9 comments · Fixed by #5975
Assignees
@elaihau
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Aug 7, 2019 •
edited
Loading

Description

configured task is displayed incorrectly in Terminal -> Run Task menu after refreshing page

Reproduction Steps

  1. Use npm extension
  2. Configure some npm task and refresh page
  3. Go to Terminal -> Run Task menu
  4. You can see
    configured_bug
  5. Try to run the task

Please see the video: https://youtu.be/9RP7DxAi7eI

OS and Theia version:
Ubuntu 18.04. Chrome.
d47d42e
@RomanNikitenko RomanNikitenko added bug bugs found in the application tasks issues related to the task system labels Aug 7, 2019
@vince-fugnitto
Copy link
Member

vince-fugnitto commented Aug 7, 2019 •
edited
Loading

I believe it's been fixed in master d47d42e as part of the PR #5869

@RomanNikitenko
Copy link
Contributor Author

@vince-fugnitto
What extension did you use for testing?
I still can reproduce it using npm extension.

@akosyakov
Copy link
Member

@vince-fugnitto #5869 only make sure that tasks are loaded, the issue seems to be not in the failed loading, but bogus representation

@vince-fugnitto
Copy link
Member

I notice the bug if one configures the task and keeps the tasks.json opened (incorrect data is displayed). If one configures the task, closes the tasks.json and reloads the application it works correctly.

@akosyakov
Copy link
Member

@RomanNikitenko @vince-fugnitto @elaihau We need to fix #5013. The issue is that it will completely change how tasks are loaded from the file. You should consider whether it is worth to invest time into fixing bugs with current approach if it has to be discarded at the end with another. Maybe it would be better already implement loading tasks properly via preferences instead.

@elaihau
Copy link
Contributor

elaihau commented Aug 12, 2019 •
edited
Loading

this might be related to an old problem: our TaskConfiguration.equals() is not reliable and capable enough to handle all cases.

Yesterday I started working on a newer version of that function. give me some time testing my code. i will keep you posted.

@elaihau elaihau self-assigned this Aug 18, 2019
elaihau pushed a commit that referenced this issue Aug 18, 2019
use task definition as a reference to compare tasks
943792e 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 18, 2019
use task definition as a reference to compare tasks
548d6da 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau mentioned this issue Aug 18, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Aug 18, 2019
use task definition as a reference to compare tasks
0f8e3c6 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau
Copy link
Contributor

elaihau commented Aug 18, 2019

changes from both #5975 and #5915 are needed to fix this one.

elaihau pushed a commit that referenced this issue Aug 21, 2019
use task definition as a reference to compare tasks
528ded1 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau
Copy link
Contributor

elaihau commented Aug 21, 2019

@RomanNikitenko could you please take a look at #5975 since you created this issue ? Thank you !

@RomanNikitenko
Copy link
Contributor Author

@elaihau
I'm going to test the changes today, thank you!

elaihau pushed a commit that referenced this issue Aug 23, 2019
use task definition as a reference to compare tasks
0ce0e93 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 25, 2019
use task definition as a reference to compare tasks
56c44db 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 26, 2019
use task definition as a reference to compare tasks
8fcc050 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit to elaihau/theia that referenced this issue Aug 27, 2019
use task definition as a reference to compare tasks
fc16bd8 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed eclipse-theia#5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 27, 2019
use task definition as a reference to compare tasks
f235bda 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 28, 2019
use task definition as a reference to compare tasks
8555761 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 28, 2019
use task definition as a reference to compare tasks
8eec728 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 28, 2019
@elaihau
use task definition as a reference to compare tasks
fce7783 
- Although task users have much flexibility to define tasks through
contributing to the Task definitions, TaskConfiguration.equals() and
ContributedTaskConfiguration.equals() compare certain properties of task
configs, and thus are not reliable enough. With changes in this pull
request, Theia uses task definitions as a reference to decide which
properties in task configs should be considered in comparison.
- fixed #5878

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use task definition as a reference to compare tasks eclipse-theia/theia
4 participants
@akosyakov @RomanNikitenko @elaihau @vince-fugnitto