Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] better tabbar support for multi-root workspaces #5921

Closed
vince-fugnitto opened this issue Aug 12, 2019 · 0 comments · Fixed by #5924
Closed

[core] better tabbar support for multi-root workspaces #5921

vince-fugnitto opened this issue Aug 12, 2019 · 0 comments · Fixed by #5924
Labels
enhancement issues that are enhancements to current functionality - nice to haves multi-root issues related to multi-root support

Comments

@vince-fugnitto
Copy link
Member

Description

The tabbar support for multi-root workspaces needs to be improved in order to more easily make the distinction of which root the file resides in. Currently, when hovering over editor tabbars, we display the relative root as an html title. This isn't enough in a multi-root workspace.

Example

Roots Filename 1 Filename 2 Expected Actual
cpp, console README.md README.md cpp/README.md, console/README.md README.md, README.md
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves multi-root issues related to multi-root support labels Aug 12, 2019
vince-fugnitto added a commit that referenced this issue Aug 13, 2019
@vince-fugnitto
Update editor tabbar captions for better multi-root support
ccd9bce 
Fixes #5921

- updated the editor's caption (used for tabbars) in order
to better support multi-root workspaces, and align with VSCode.
Currently, when in a multi-root workspace there is no way to
easily distinguish which root the file resides in. With this
change the entire path is displayed, similarly to the explorer.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Aug 13, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Aug 13, 2019
@vince-fugnitto
Update editor tabbar captions for better multi-root support
a6720b5 
Fixes #5921

- updated the editor's caption (used for tabbars) in order
to better support multi-root workspaces, and align with VSCode.
Currently, when in a multi-root workspace there is no way to
easily distinguish which root the file resides in. With this
change the entire path is displayed, similarly to the explorer.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves multi-root issues related to multi-root support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update editor tabbar captions for better multi-root support eclipse-theia/theia
1 participant
@vince-fugnitto