Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explorer/navigator] implement 'More' toolbar item with context menu #5951

Closed
vince-fugnitto opened this issue Aug 15, 2019 · 2 comments · Fixed by #5953
Closed

[explorer/navigator] implement 'More' toolbar item with context menu #5951

vince-fugnitto opened this issue Aug 15, 2019 · 2 comments · Fixed by #5953
Labels
enhancement issues that are enhancements to current functionality - nice to haves navigator issues related to the navigator/explorer

Comments

@vince-fugnitto
Copy link
Member

Description

Based on #5946 (comment)

Support "More" toolbar item and context menu for the explorer widget which will contain helpful methods for the view (ex: Add Folder to Workspace)

A similar implementation is present in the Git explorer:

Implementation Details

  1. should the toolbar item be always displayed? or should it only be displayed in a single-root workspace?
  2. which context menu items should be displayed?
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves navigator issues related to the navigator/explorer labels Aug 15, 2019
@vince-fugnitto vince-fugnitto mentioned this issue Aug 15, 2019
Closed
@akosyakov
Copy link
Member

It should display what it used to display in the context menu before introducing view containers.

@vince-fugnitto
Copy link
Member Author

I started implementing the 'more' toolbar but I realized a lot of the commands will need to be updated / duplicated in order to support the feature. They mostly use a UriAwareCommandHandler and since there is no longer a root node present (with a URI) the toolbar is not visible until a selection is made in the widget. I will need to adjust or duplicate the commands to default to the root node if possible.

image

vince-fugnitto added a commit that referenced this issue Aug 15, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
a591970 
Fixes #5951

- implement the 'more' toolbar item for the explorer which
triggers a context menu which displays helpful commands.
- mainly used to limit the impact of recent developments which
removes the root node from the tree and thus the ability to
perform actions directly on the root.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Aug 15, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Aug 16, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
c171f29 
Fixes #5951

- implement the 'more' toolbar item for the explorer which
triggers a context menu which displays helpful commands.
- mainly used to limit the impact of recent developments which
removes the root node from the tree and thus the ability to
perform actions directly on the root.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
d0ec6b2 
Fixes #5951

- implement `more` toolbar item to display workspace root specific commands.
- implement 'new file root' and 'new folder root' commands which call the generic createFile and createFolder commands.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
a8ca7a9 
Fixes #5951

- implemented `More Actions...` toolbar item for the explorer which is
used to host commands specific to the workspace root whenever there is a
single-root workspace currently opened. The initial implementation adds
only a subset of available commands which make sense for the workspace root.
The following commands have been added:
1. new file
2. new folder
3. open in terminal
4. find in folder

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
e8cb6f6 
Fixes #5951

- implemented `More Actions...` toolbar item for the explorer which is
used to host commands specific to the workspace root whenever there is a
single-root workspace currently opened. The initial implementation adds
only a subset of available commands which make sense for the workspace root.
The following commands have been added:
1. new file
2. new folder
3. open in terminal
4. find in folder

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
e58e858 
Fixes #5951

- implemented `More Actions...` toolbar item for the explorer which is
used to host commands specific to the workspace root whenever there is a
single-root workspace currently opened. The initial implementation adds
only a subset of available commands which make sense for the workspace root.
The following commands have been added:
1. new file
2. new folder
3. open in terminal
4. find in folder

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
4baff8d 
Fixes #5951

- implemented `More Actions...` toolbar item for the explorer which is
used to host commands specific to the workspace root whenever there is a
single-root workspace currently opened. The initial implementation adds
only a subset of available commands which make sense for the workspace root.
The following commands have been added:
1. new file
2. new folder
3. open in terminal
4. find in folder
5. add folder to workspace
6. compare with...

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 21, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
b012d55 
Fixes #5951
Fixes #6010

- added a toolbar item which contains multiple commands for the explorer.
- adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands
which deal with single and multi-root workspaces.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 21, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
9d73b7d 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of mutliple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

- added a toolbar item which contains multiple commands for the explorer.
- adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands
which deal with single and multi-root workspaces.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 21, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
811e6c1 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of mutliple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 21, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
e016d58 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of multiple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 23, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
d7c686a 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of multiple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 23, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
24585fe 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of multiple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 23, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
d4aee1e 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of multiple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 23, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
82e6662 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of multiple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 26, 2019
@vince-fugnitto
Implement 'more' toolbar item for the explorer
e4390f4 
Fixes #5951
Fixes #6010

- Added a new toolbar item for the `explorer` which consists of multiple commands.
- Adjusted the `WorkspaceRootUriAwareCommandHandler` to better handle commands which
can be used by the workspace root in both a single and multi-root workspace.
- Added the command `New File` to the toolbar item.
- Added the command `New Folder` to the toolbar item.
- Added the command `Add Folder to Workspace...` to the toolbar item.
- Added the command `Compare With...` to the toolbar item.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves navigator issues related to the navigator/explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[explorer] implement 'more' toolbar item for the explorer eclipse-theia/theia
2 participants
@akosyakov @vince-fugnitto