When opening command palette by cmd+shift+p, the cursor is to the left of ">" sign #6011
Labels
Comments
|
That's very odd, I only notice the bug on Safari. |
vince-fugnitto
added
bug
vince-fugnitto
added a commit
that referenced
this issue
Oct 22, 2019
Fixes #6011 Fixes incorrect command palette cursor position especially on Safari browser. Added additional handling to verify that if no selection is currently present, force the cursor at the end of the input. Inspired by a similar implementation in VS Code. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
3 tasks
vince-fugnitto
added a commit
that referenced
this issue
Nov 1, 2019
Fixes #6011 Fixes incorrect command palette cursor position especially on Safari browser. Added additional handling to verify that if no selection is currently present, force the cursor at the end of the input. Inspired by a similar implementation in VS Code. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
akosyakov
pushed a commit
to akosyakov/theia
that referenced
this issue
Feb 24, 2020
Fixes eclipse-theia#6011 Fixes incorrect command palette cursor position especially on Safari browser. Added additional handling to verify that if no selection is currently present, force the cursor at the end of the input. Inspired by a similar implementation in VS Code. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When opening command palette by cmd+shift+p, the cursor is to the left of ">" sign.
It should be to the right.
Reproduction Steps
git clone latest Theia.
Follow the instructions to run Theia in a browser.
Open localhost:3000 in Safari.
Press cmd + shift + p.
Observe that cursor is to the left of ">".
OS and Theia version:
Mac OS 10.14.6
Pulled from master, latest commit f46ebf4
The text was updated successfully, but these errors were encountered: