Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin system should prefer listed plugins instead of dependencies #6036

Closed
akosyakov opened this issue Aug 25, 2019 · 0 comments · Fixed by #6038
Closed

plugin system should prefer listed plugins instead of dependencies #6036

akosyakov opened this issue Aug 25, 2019 · 0 comments · Fixed by #6038
Assignees
@akosyakov
Labels
bug bugs found in the application critical critical bugs / problems plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

akosyakov commented Aug 25, 2019 •
edited
Loading

In order to reproduce:

  • put a flutter and dart VS Code extensions as vsix files to plugins folder
  • start Theia
  • you will see that instead of deploying Dart from vsix file the plugin system download dart extension from the marketplace

cc @JPinkney @theia-ide/plugin-system
@akosyakov akosyakov added bug bugs found in the application plug-in system issues related to the plug-in system labels Aug 25, 2019
@akosyakov akosyakov self-assigned this Aug 25, 2019
@akosyakov akosyakov changed the title plugin in system should prefer listed plugins instead of dependencies plugin system should prefer listed plugins instead of dependencies Aug 25, 2019
@akosyakov akosyakov added the critical critical bugs / problems label Aug 25, 2019
akosyakov added a commit that referenced this issue Aug 25, 2019
@akosyakov
fix #6036: prefer listed plugins to dependencies
8bba433 
otherwise the wrong version gets installed from a marketplace instead of from local vsix file for example

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 25, 2019
@akosyakov
fix #6036: prefer listed plugins to dependencies
1fad696 
otherwise the wrong version gets installed from a marketplace instead of from local vsix file for example

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Aug 25, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Aug 25, 2019
@akosyakov
fix #6036: prefer listed plugins to dependencies
fde7af2 
otherwise the wrong version gets installed from a marketplace instead of from local vsix file for example

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 26, 2019
@akosyakov
fix #6036: prefer listed plugins to dependencies
f7e0f4c 
otherwise the wrong version gets installed from a marketplace instead of from local vsix file for example

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application critical critical bugs / problems plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prefer listed plugins to dependencies eclipse-theia/theia
1 participant
@akosyakov