quickpick didn't open with 1 item

[i053322]

Description

In the new version of theia ( theiaide/theia-full:next ) when I open quickpick with one item it doesn't show the item.
It works with multi items.

Reproduction Steps

I created vsix from github ( with 1 item)
https://github.com/i053322/quickpickexample
Load the VSIX and press F1 and choose Hello World

OS and Theia version:
master

Diagnostics:
I checked it on version 0.9.0 and it worked.
It it also worked on VS CODE

[akosyakov]

cc @JPinkney @vinokurig

[vince-fugnitto]

The same is true for the quickPick in the application.
If the quickPick only has one item, the item is simply executed instead of displaying the dropdown.

https://github.com/theia-ide/theia/blob/85b75768f702656db4ee8ff6eaad303be8102643/packages/core/src/browser/quick-open/quick-pick-service-impl.ts#L41-L43

Update
Removing this part of the code makes the quickPick [work] with a single item. Is this something we want to remove to align with VSCode?

[akosyakov]

I checked it on version 0.9.0 and it worked.

@vince-fugnitto so it is not true? If it is not a regression then it is fine not to fix for 0.10.0

Removing this part of the code makes the quickPick [work] with a single item. Is this something we want to remove to align with VSCode?

For VS Code extensions APIs should work like in VS Code. In Theia core it can behave differently, maybe we need an option to align the plugin system behaviour with VS Code. We should look at all clients outside of the plugin system and see for them what we want. I won't be surprised that it is different in VS Code as well for VS Code extensions and internal clients.

[vince-fugnitto]

I checked it on version 0.9.0 and it worked.

@vince-fugnitto so it is not true? If it is not a regression then it is fine not to fix for 0.10.0

I believe the regression comes from the fact that we now call the quickPick from core in the plugin-ext.

https://github.com/theia-ide/theia/blob/85b75768f702656db4ee8ff6eaad303be8102643/packages/plugin-ext/src/main/browser/quick-open-main.ts#L284-L296

1bbdf7c#diff-5b814eef870b0daed9365c04d6aaf9abR266

[akosyakov]

@vince-fugnitto I see, actually it sounds strange now that on show we don't show for a single item, but changing it now we break other clients like git extension.

I wonder can we add a flag like runIfSingle which is true by default, but set to false for the plugin system call? Could you do it?

[vince-fugnitto]

@vince-fugnitto I see, actually it sounds strange now that on show we don't show for a single item, but changing it now we break other clients like git extension.

I wonder can we add a flag like runIfSingle which is true by default, but set to false for the plugin system call? Could you do it?

Sure, the flag should be enough I believe :)

[offer8]

@vince-fugnitto will it be part of next theia v0.10.0 release ?

[vince-fugnitto]

@offer8 yes it's included in last Thursday's release of v0.10.0