Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus Open workspace button in the navigator on activation #6140

Closed
akosyakov opened this issue Sep 9, 2019 · 3 comments · Fixed by #6158
Closed

focus Open workspace button in the navigator on activation #6140

akosyakov opened this issue Sep 9, 2019 · 3 comments · Fixed by #6158
Assignees
@kpge
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer ui/ux issues related to user interface / user experience

Comments

@akosyakov
Copy link
Member

Screen Shot 2019-09-09 at 12 10 53

Right now the root node is selected, which is not very useful. One even cannot use tab to give a focus to the button. Is it a button at all?
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves good first issue good first issues for new contributors navigator issues related to the navigator/explorer ui/ux issues related to user interface / user experience help wanted issues meant to be picked up, require help and removed enhancement issues that are enhancements to current functionality - nice to haves labels Sep 9, 2019
@akosyakov
Copy link
Member Author

Also ... -> Auto Reveal does not make sense in this context.

@kpge kpge self-assigned this Sep 11, 2019
@kpge
Copy link
Contributor

kpge commented Sep 11, 2019

I think it's necessary to show the focus effect in navigator when the workspace is empty, because this can show user the navigator is focused, and press tab can select the button.
I will create a PR to fix other suggestion.

@akosyakov
Copy link
Member Author

I think it's necessary to show the focus effect in navigator when the workspace is empty, because this can show user the navigator is focused, and press tab can select the button.

Tab does not seem to select the button.

@kpge kpge mentioned this issue Sep 11, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpge kpge

Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add enter key event handler and focus style to open button in navigator kpge/theia
2 participants
@akosyakov @kpge