Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enter key event handler and focus style to open button in navigator #6158

Merged

Conversation

kpge
Copy link
Contributor

@kpge kpge commented Sep 11, 2019

What it does

fix: #6140

  1. add button:focus style when the button is focused (the same with button:hover)
  2. hide more tool item on the toolbar in navigator when the workspace is empty.

How to test

1.open theia browser and close workspace
2.open Explorer sidebar, and press tab key to select open workspace button
3.press enter key to open open workspace dialog

Review checklist

Reminder for reviewers

@akosyakov akosyakov added the navigator issues related to the navigator/explorer label Sep 11, 2019
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! Thank you!

@akosyakov akosyakov added the shell issues related to the core shell label Sep 11, 2019
@akosyakov
Copy link
Member

@jbicker don't forget to help with merging

@jbicker jbicker merged commit c9a6216 into eclipse-theia:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer shell issues related to the core shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

focus Open workspace button in the navigator on activation
3 participants