Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monaco | preferences] format document not available without a workspace #6263

Closed
vince-fugnitto opened this issue Sep 25, 2019 · 1 comment
Closed

[monaco | preferences] format document not available without a workspace #6263

vince-fugnitto opened this issue Sep 25, 2019 · 1 comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Description

The command format document is unavailable when no workspace is currently opened.
This means that when editing the preferences the command is disabled which gives a bad user experience. For comparison, the command is available in vscode.

Steps to Reproduce

  1. open the application without a workspace
  2. open the preferences widget
  3. attempt to format the document using the editor context menu (the command is disabled)
Screenshots

Without a Workspace


Screen Shot 2019-09-25 at 11 51 17 AM

With a Workspace


Screen Shot 2019-09-25 at 11 52 44 AM
@vince-fugnitto vince-fugnitto added the bug bugs found in the application label Sep 25, 2019
@akosyakov akosyakov added help wanted issues meant to be picked up, require help monaco issues related to monaco preferences issues related to preferences labels Sep 26, 2019
@vince-fugnitto
Copy link
Member Author

I verified after the changes from #8112 and the command is available 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco preferences issues related to preferences
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @vince-fugnitto