-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace json theia extension with vscode one #8112
Conversation
496d673
to
66b8039
Compare
66b8039
to
b2856fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b2856fd
to
9ca1f80
Compare
@vince-fugnitto How do you reproduce it. I've just tried latest state in Gitpod: Could you check terminal that VS Code extensions are downloaded successfully for you? |
I re-verified and it works correctly now, I'm not sure how I got in that weird state before. |
9ca1f80
to
f3c7996
Compare
f3c7996
to
ad2f812
Compare
It is required for #7100 @vince-fugnitto Could you have a look again please? Is there anything else should be addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akosyakov I verified the changes and they work well. I've verified that:
settings.json
: both theia and vscode preferences has problem marker support and autocompletionlaunch.json
: both theia and vscode debug has problem marker support and autocompletionkeymaps.json
: the entries are correctly populated like before, and the updates are applied correctly
I also looked over the code and did not see anything that looked incorrect.
Hello @akosyakov What is the behavior when multiple jsonSchemas are registered for an identical fileMatch pattern? Basically do |
They are added as extra schemas. You will need to check how json-language-featuers built-in extension handles it. |
I'm updating deprecation notes with a link to VS Code docs about how to integrate a language server via VS Code extension and merging if there are no objections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it in the context of Tasks functionality.
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Use VS Code extensions instead: https://code.visualstudio.com/api/language-extensions/language-server-extension-guide Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Fixes #118 Following PR eclipse-theia/theia#8112, @theia/json should no longer be used. It's still present in the doc here, and so will cause issues. Signed-off-by: Marc Dumais <marc.dumais@gmail.com>
What it does
Fixes: #7981
Fixes: #3983
Please see CHANGELOG for breaking changes.
How to test
How to test
from Support relative paths for JSON schema associations (Fix #7140) #7225Review checklist
Reminder for reviewers