Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron][menu] Selection menu is missing from the electron app #6425

Open
kittaakos opened this issue Oct 21, 2019 · 1 comment
Open

[electron][menu] Selection menu is missing from the electron app #6425

kittaakos opened this issue Oct 21, 2019 · 1 comment
Labels
bug bugs found in the application electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

Description

I could not do Select All with Cmd+A on an input field; such as SCM, SIW. It turned out, the entire Selection menu is missing from the electron application. The registration seems to be correct in the monaco-menu module but is missing from ElectronMenuContribution#setMenu once the app has the 'ready' state.

I do not know if this is a monaco issue, or simply, we cannot play with the menu item indices on macOS, as we have the special Theia menu item at 0 position.

I am looking into this.

Reproduction Steps

OS and Theia version:

macOS, f255f5a

Diagnostics:

@kittaakos kittaakos self-assigned this Oct 21, 2019
@kittaakos
Copy link
Contributor Author

I do not know if this is a monaco issue

It is this: #446
The menu items are not visible, because the underlying command is not visible at app start up. And we do not support dynamic menu items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application electron issues related to the electron target
Projects
None yet
Development

No branches or pull requests

2 participants