-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[electron] The Select All
command executes incorrectly
#6428
Comments
We have to distinguish between Theia command and pure DOM command executions just like VS Code does: We have to do the same for |
VS Code makes differences whether the text has the focus in the active editor or not. We don't: theia/packages/editor/src/browser/editor-keybinding-contexts.ts Lines 25 to 28 in 9457f80
|
There is |
From now on, when executing the `Undo`, `Redo`, and `Select All` command handlers, we do not focus the `current` editor but follow the following execution order: - Executes on the `current` editor if it has text focus. - Otherwise, if the `document.activeElement` is either an `input` or a `textArea`, executes the browser's built-in command on it. - Otherwise, executes on the `current` editor after setting the focus on it. Closes: #6428 Closes: #2756 Signed-off-by: Akos Kitta <kittaakos@typefox.io> rewrote it a bit. Signed-off-by: Akos Kitta <kittaakos@typefox.io> aligned name. Signed-off-by: Akos Kitta <kittaakos@typefox.io> s Signed-off-by: Akos Kitta <kittaakos@typefox.io>
From now on, when executing the `Undo`, `Redo`, and `Select All` command handlers, we do not focus the `current` editor but follow the following execution order: - Executes on the `current` editor if it has text focus. - Otherwise, if the `document.activeElement` is either an `input` or a `textArea`, executes the browser's built-in command on it. - Otherwise, executes on the `current` editor after setting the focus on it. Closes: #6428 Closes: #2756 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #6428 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Description
I have forcefully enabled all menu items in electron to see the
Selection
menu (#6425). When I did aSelect All
, not the focus item was selected, but the monaco editor's content. It works perfectly in the browser.Electron:
Browser:
Note, the
Select All
does not work in electron either when I close the editor and have the focus on aninput
.Reproduction Steps
OS and Theia version:
macOS, f255f5a
Diagnostics:
The text was updated successfully, but these errors were encountered: