Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron] Ctrl/Cmd+A does not select the content of the quick open item #2756

Closed
kittaakos opened this issue Sep 1, 2018 · 2 comments · Fixed by #7481
Closed

[electron] Ctrl/Cmd+A does not select the content of the quick open item #2756

kittaakos opened this issue Sep 1, 2018 · 2 comments · Fixed by #7481
Labels
electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

This Select All functionality works in VS Code.
@kittaakos kittaakos added the electron issues related to the electron target label Sep 1, 2018
@paul-marechal
Copy link
Member

If I do ctrl+a in the quick open menu, it works, but if I click in the title menus, it doesn't...

@kittaakos
Copy link
Contributor Author

It works from the browser, not with the electron example. Tested with 93fb9e7.

kittaakos pushed a commit that referenced this issue Mar 14, 2020
GH-6428: Fixed Undo, Redo, and Select All
85d24fe 
From now on, when executing the `Undo`, `Redo`, and `Select All` command
handlers, we do not focus the `current` editor but follow the following
execution order:

 - Executes on the `current` editor if it has text focus.
 - Otherwise, if the `document.activeElement` is either an `input` or a
 `textArea`, executes the browser's built-in command on it.
 - Otherwise, executes on the `current` editor after setting the focus
on it.

Closes: #6428
Closes: #2756

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

rewrote it a bit.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

aligned name.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

s

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Mar 14, 2020
GH-6428: Fixed Undo, Redo, and Select All
2fe2aad 
From now on, when executing the `Undo`, `Redo`, and `Select All` command
handlers, we do not focus the `current` editor but follow the following
execution order:

 - Executes on the `current` editor if it has text focus.
 - Otherwise, if the `document.activeElement` is either an `input` or a
 `textArea`, executes the browser's built-in command on it.
 - Otherwise, executes on the `current` editor after setting the focus
on it.

Closes: #6428
Closes: #2756

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Mar 14, 2020
Closed
1 task
@kittaakos kittaakos mentioned this issue Apr 1, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron issues related to the electron target
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @paul-marechal