Fix 'Find Next' action at using Enter

[RomanNikitenko]

What it does

Fixes #7460

I investigated the issue and found that an editor gets focus before execution a command.
It leads to the bug described in the issue.

How to test

Please use steps to reproduce from #7460

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

[RomanNikitenko]

To be honest, I don't know why editor.focus() was added before execution a command.

@akosyakov
could you take a look
is it really required or it was a workaround for some command.

I tested these changes using tests from #7265.
They passed successfully for me.

It confuses me that editor.focus() lives here about 3 years, so maybe I should investigate more deeply how it worked before Monaco upgrade - maybe something was changed on VS Code side...

[kittaakos]

@RomanNikitenko, I am currently refactoring the monaco-command-registry, monaco-commands, and monaco-editor-provider modules. Can we wait a day or so with this PR? It's not about any possible conflicts, but I might end up removing the execute method from the Monaco command registry.

CC: @akosyakov

[RomanNikitenko]

@kittaakos

Can we wait a day or so with this PR?

It's OK for me, in the meantime I can investigate how it worked before upgrade Monaco and what was changed on VS Code side

[kittaakos]

I can investigate how it worked before upgrade Monaco and what was changed on VS Code side

That would be a great help, also when it comes to the verification of #6428.

[akosyakov]

@RomanNikitenko strange that it worked before with focus.

[RomanNikitenko]

Closing in favor of #7481

[RomanNikitenko]

strange that it worked before with focus

Before upgrade Monaco Find Next action was executed without using the method, so an editor did not get a focus at execution a command.
I checked it for 739522d:

For current master branch:

Something similar you can see in the second part of the comment: #7481 (review)

[akosyakov]

@RomanNikitenko thanks for checking