Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search behaves differently than it used to (and compared to VS code) #7460

Closed
csweichel opened this issue Mar 31, 2020 · 2 comments · Fixed by #7481
Closed

Search behaves differently than it used to (and compared to VS code) #7460

csweichel opened this issue Mar 31, 2020 · 2 comments · Fixed by #7481
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco

Comments

@csweichel
Copy link

Description

When searching in an editor (Cmd+F) is used to be able to jump to the next search result by pressing enter. Now, when pressing enter the editor gets the focus with the cursor placed at the last found result.

Reproduction Steps

  1. Open an editor
  2. Open the search box (Cmd+F) and search for a string that's present in the editor
  3. Press enter

OS and Theia version:
latest master
@akosyakov
Copy link
Member

It seems to be a regression from latest Monaco migration. cc @RomanNikitenko

@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco labels Mar 31, 2020
@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Mar 31, 2020 •
edited
Loading

@csweichel
yes, I can reproduce the issue, thank you for reporting!

@RomanNikitenko RomanNikitenko mentioned this issue Mar 31, 2020
Closed
1 task
@kittaakos kittaakos mentioned this issue Apr 1, 2020
Merged
2 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Apr 2, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco
Projects
None yet
Milestone
No milestone
3 participants
@akosyakov @csweichel @RomanNikitenko