Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration tests for typescript language #7265

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 3, 2020

What it does

Added integration tests for typescript.

How to test

CI should be green.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added monaco issues related to monaco test issues related to unit and api tests labels Mar 3, 2020
@vince-fugnitto
Copy link
Member

@akosyakov I like the changes and the fact we can use this test as a basis for additional tests, and for new languages as well. Should you amend the pull-request, I don't see Travis started?

@akosyakov
Copy link
Member Author

@vince-fugnitto It is just a start, I will work more next days. For now this PR only enable awaiting of typescript extension activation and do one dummy test.

@akosyakov akosyakov force-pushed the ak/monaco_tests branch 2 times, most recently from a0e57d0 to 8dfde42 Compare March 4, 2020 10:13
@akosyakov
Copy link
Member Author

Weird that travis does not start job for this PR. Do we only build PRs against master?

@vince-fugnitto
Copy link
Member

Weird that travis does not start job for this PR. Do we only build PRs against master?

I'm not sure but it might be the case with this config:

theia/.travis.yml

Lines 65 to 67 in 357b8e9

branches:
only:
- master

@akosyakov
Copy link
Member Author

Added more tests for reveal definition for different kind of links (internal, external) and between different widgets (editor and editor preview). It looks good.

I will add tests for peek widget tomorrow and then for other language features, hope it will go faster.

@akosyakov
Copy link
Member Author

I've added tests for peek definition and will test other features after the lunch. I've done with the VSX Registry integration and will have more time for testing Monaco this week :)

@akosyakov akosyakov force-pushed the ak/monaco_tests branch 4 times, most recently from 187886a to a14ac9e Compare March 16, 2020 14:18
@akosyakov akosyakov force-pushed the ak/monaco_tests branch 10 times, most recently from c4051f2 to f51a767 Compare March 18, 2020 12:41
@akosyakov
Copy link
Member Author

I've increased timeout. Could you try again?

@RomanNikitenko
Copy link
Contributor

maybe your machine is not enough fast

I thought my machine was good enough until you asked me...
😃

Testing...

@RomanNikitenko
Copy link
Contributor

@akosyakov
Tested after update, one test was still failing

test1

I wonder do you have some custom plugins installed

you are right, found two extra extension in plugins folder
additional_plugins

After removing them I can not reproduce the problem - all tests are success for me!

@akosyakov
Copy link
Member Author

akosyakov commented Mar 25, 2020

@RomanNikitenko I will keep timeouts, if it slows down ci, i will reduce them. It should not do it for successful builds.

@akosyakov
Copy link
Member Author

Currently tests are based on generated src-gen/server.js file. I will change it to generate a custom test file under src-gen to prevent breaking them by changing server generator.

@RomanNikitenko RomanNikitenko force-pushed the upgrade_monaco branch 2 times, most recently from d805417 to d00c56b Compare March 27, 2020 08:44
@RomanNikitenko
Copy link
Contributor

@akosyakov

I will change it to generate a custom test file under src-gen to prevent breaking them by changing server generator.

Are you going to do it within current PR or a separate PR?

@akosyakov
Copy link
Member Author

@RomanNikitenko I will rebase and clean up the PR on Monday and then ping you.

@akosyakov akosyakov changed the base branch from upgrade_monaco to master March 30, 2020 06:25
@akosyakov
Copy link
Member Author

@RomanNikitenko tests are changed to use own test file, instead of generated server.ts

@akosyakov
Copy link
Member Author

@vince-fugnitto Changed to master and travis is running again, tests are passing now.

@RomanNikitenko RomanNikitenko self-requested a review March 30, 2020 11:10
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the tests multiple times: they pass successfully and look stable for me!

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

I've updated CHANGELOG and applied all suggestions, going to merge it the build is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco plug-in system issues related to the plug-in system test issues related to unit and api tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants