Upgrade to LSP 6.0.0 and Monaco 0.19.3

[RomanNikitenko]

What it does

Closes #6900

Upgrade to:

• LSP: 6.0.0
• theia/monaco-editor-core: 0.19.3
• vscode-ws-jsonrpc: 0.2.0
• depends on Bump monaco version TypeFox/monaco-languageclient#199
• depends on Implemented support for "LocationLink" in the "onDefinition" method TypeFox/monaco-languageclient#191
• support Codicons in the quick pick items support octicon in the quick pick items #5412
• upgrade to the latest Monaco Upgrade to the latest Monaco #6900
• Fix Slow scrolling in editors using mouse wheel for Firefox

TODO

• align signatures for monaco/index.d.ts Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• add Peek submenu and the corresponding actions Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• provide proper column at go to definition Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • Provided fix
  • applied tests, commented add integration tests for typescript language #7265 (review)
• remove referencesController and test peek widget Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (review)
  • tested: Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment), need more investigation.
• remove checks like: Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (review)
  • removed, commented Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• revert the hotfix for IME support Stop dispatching to keybindings in editing coposition text. #6673 and check whether IME support is fixed in newer Monaco
  • reverted the hotfix, but it's required more investigation why it doesn't work for Theia: Stop dispatching to keybindings in editing coposition text. #6673 (comment)
• check Slow scrolling in editors using mouse wheel [Firefox/Ubuntu] #6390 (comment)
  • tested: Slow scrolling in editors using mouse wheel [Firefox/Ubuntu] #6390 (comment)
• Peek Declaration problem Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • investigated: Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • created the separate issue Create editor context menu based on context #7368 as it's relevant for master branch as well
• Fix quick fixes menu Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • provided fix: Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• Go to Symbol commands have different title and keybindings to VS Code Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • renamed Open Workspace Symbol... => Go to Symbol in Workspace...: 445104f
  • commented Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• Selection menu in the main bar is not aligned with VS Code anymore Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • fixed Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• check that editor configurations are aligned Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • investigated Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • updated editor configurations Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• test tasks integration for VS Code extensions
  • elaihau (thanks!) tested task palette Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • steps for testing Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• Workspace icons are missing
  • fixed by 050166b
• check CallHierarchy Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • latest typescript VS Code extension is required Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • created issue Migrate to the latest typescript VS Code extension #7395
• Apply codicons for Configure Task action
  • applied Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
• Test codicons for command palette
  • found some issues Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • fix styles Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)
  • created the issue for VS Code Codicons are not rendered when filtering in quick pick microsoft/vscode#93303
  • created the issue for Theia Codicons are not rendered when filtering in quick pick #7429

How to test

• test language features with VS Code extension:
  • test that features are available in the editor context menu and in quick command palette (automated)
  • a declaration is revealed when following the reference (automated)
  • focus belongs to a proper editor after following a reference (for internal and outside references, from editor to editor preview and view versa) (automated)
  • reference peek is still opened after following a reference (for internal and outside references, from editor to editor preview and view versa) (automated)
  • esc closes reference peek widget (automated)
  • completion items are properly resolved and inserted (automated)
  • focus belongs to a proper editor on peek definition (for internal and outside references, from editor to editor preview and view versa) (automated)
  • check that rename work inside the file and across files (automated)
  • check that arguments are proposed by the signature help (automated)
  • check that hover is present with properly rendered docs (automated)
  • check that symbol occurrences is highlighted when a declaration or reference is selected (automated)
  • check that go to (type|implementation) definition works properly, i.e. definition is revealed (automated)
  • check that code lens work properly (automated)
    • run/debug code lenses: https://github.com/kasecato/vscode-javadebug-sample. One has to install vscode java, debug and test extensions.
  • check that code actions work properly (quick fixes) (automated)
  • check that document and selection formatting work properly (automated)
  • check color provider with css colors
  • check link provider with links in html
  • check that folding ranges are properly provided for js, css and html
  • check go to symbol command
  • check open workspace symbol command
• test quick palette:
  • proper keys are displayed for the quick command palette, i.e. they are displayed and a corresponding Monaco command can be triggered by such keybinding
  • use sample vscode extension
  • use fuzzy search
• test vscode tree view (that context keys work properly)
• test plugin editor decorations, for example with power mode extension
• test debug console input editor
• test debug breakpoint editor
• test that preferences are propagated as config key values: change editor preferences and check whether they are reflected
• test language auto detection
• test edit menu with editor
• test selection menu with editor
• test editor context menu
• smoke test some VS Code extensions like go, python, just use editor for a bit, check backend and frontend logs for errors
• test manually task related functionality Upgrade to LSP 6.0.0 and Monaco 0.19.3 #7149 (comment)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

[akosyakov]

@RomanNikitenko Could you reference relevant issue and fill int How to test with boxes from previous migration please?

[RomanNikitenko]

@akosyakov
I updated the PR, but looks like ci build failed because of tests. I'll try to fix it today.

[RomanNikitenko]

I found that Peek actions are coming as items of Peek submenu in vs code, so I'm going to align it for theia.

[akosyakov]

@RomanNikitenko ok, I will start testing it a bit this week.

[akosyakov]

btw thank you for such diligent work on updating monaco typings 👍

[akosyakov]

@RomanNikitenko I've started adding tests in #7265 against this PR. I will stabilise and add more tests next days. They should cover How to test section of this PR eventually.

[RomanNikitenko]

@RomanNikitenko I've started adding tests in #7265 against this PR. I will stabilise and add more tests next days. They should cover How to test section of this PR eventually.

I think it will really help to test the current changes and will speed up the process of testing of next Monaco upgrade!

Thank you, Anton for doing this. l really appreciate it! 👍

[akosyakov]

I've noticed that go to definition does not jump to proper column anymore:

• put a cursor in theia/examples/browser/src-gen/backend/server.js at Container word
• use go to definition
• on master a new editor is revealed and cursor is put at Container word, with this PR it ends up at the beginning of line

[akosyakov]

Regarding to #7149 (comment)

@RomanNikitenko there is a bug in the plugin system which breaks navigation coupled with this PR, here

theia/packages/plugin-ext/src/common/plugin-api-rpc-model.ts

Lines 308 to 313 in a0e57d0

	export interface DefinitionLink {
	uri: UriComponents;
	range: Range;
	origin?: Range;
	selectionRange?: Range;
	}

there are selectionRange and origin, but there are no such properties monaco.d.ts, instead it should be targetSelectionRange and originSelectionRange

Added an integration test for it: https://github.com/eclipse-theia/theia/pull/7265/files#diff-654c40ef160f7094cc2d64d1183831e6R95-R105

btw it used to work because Monaco was guessing before, but now they removed it and rely on properties above

[RomanNikitenko]

@akosyakov

there are selectionRange and origin, but there are no such properties monaco.d.ts, instead it should be targetSelectionRange and originSelectionRange

the corresponding interface was renamed in vs code: DefinitionLink => LocationLink

Should we rename/deprecate it as well in plugin-api-rpc-model and keep it close to vs code?
or
Do you prefer to keep an old name for such cases?

[akosyakov]

@RomanNikitenko I would be fine with it, it is not public API, so should be fine to align. It is certain helps when things named the same way during investigations.

[akosyakov]

@RomanNikitenko thank you for the update, i will continue adding test tomorrow, had to focus on the vsx registry integration today. Could you check other my comments in the meantime?

[RomanNikitenko]

@akosyakov

• added Peek submenu
• added fix for go to definition.
  Checked your use case manually - looks like it's fixed now. Applied your test - it failed. Will take a look at this today more closely...

Could you check other my comments in the meantime?

sure! thank you for your comments - yesterday I added TODO section to the PR description to not lose your comments and fix them.

I'm not sure I understand the use case for testing here: #7149 (comment). I played with it yesterday - tried to add and remove the corresponding code, but I didn' see the difference. Will do it today again...

[akosyakov]

I'm not sure I understand the use case for testing here: #7149 (comment). I played with it yesterday - tried to add and remove the corresponding code, but I didn' see the difference. Will do it today again...

@RomanNikitenko You can try to remove it on master and see what is the difference. I think it was related to peek reference dialog if you follow a reference from it then a new editor should be opened and it should have the peek reference opened as well, but old widget should not. Plus focus should be transferred properly, i.e. try to move up/down or type after navigation. On master it should break when you remove with new Monaco i hope it should be fine, at least it looks like it was fixed in the upstream.

Applied your test - it failed. Will take a look at this today more closely...

Maybe something with the test itself, will have look at it tomorrow as well.

[RomanNikitenko]

@akosyakov

You can try to remove it on master and see what is the difference.

Got it! Yes, now I can reproduce it, thank you!
I added comment #7149 (comment)

[RomanNikitenko]

@akosyakov

release is done, you can rebase, clean up the history and merge

I have two questions :-)

• should I replace the function toCssClassName by method?
• I tried to reorganize git history according to resolved problems.
  But I guess it still too much.
  You can see it in the separate branch: https://github.com/eclipse-theia/theia/compare/testRebase

[akosyakov]

should I replace the function toCssClassName by method?

it would be nice, but i don't want to delay you from merging

I tried to reorganize git history according to resolved problems.

it looks great

[azatsarynnyy]

@azatsarynnyy @RomanNikitenko Can we chat somehow about what you think about finding ways to do #7100 and #7261? Instead of upgrading as we do now?

@akosyakov sure, let's plan it on Monday

[akosyakov]

@azatsarynnyy Should we meet in our dev meeting room? What time will work for you? at 15 CET?

[akosyakov]

@RomanNikitenko should anything else be done to merge it?

[azatsarynnyy]

@azatsarynnyy Should we meet in our dev meeting room? What time will work for you? at 15 CET?

@akosyakov yes, we can use the same BJN link as for dev call. 15 CET is good for us. Thanks!

[RomanNikitenko]

@akosyakov
sorry for the delay - some things on our side...

Thank you very much for your support!
I think this kind of work would be impossible without your assistance.
I really appreciate your help!