Bump monaco version #199

RomanNikitenko · 2020-01-24T09:00:03Z

Bump Monaco to 0.19.3

I created the branch based on #198 and tried to fix the compilation errors.

…ient into TypeFox-master

A new enum has been added to the vscode compatibility layer (as vscode-languageserver rely on it). Also the severity enum converter use an internal version of the enum to avoid relying on the vscode module.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

gitpod-io-legacy-app · 2020-01-24T09:00:06Z

Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

akosyakov · 2020-01-27T02:16:20Z

@RomanNikitenko ping me if you have any Qs

RomanNikitenko · 2020-01-27T15:57:26Z

@akosyakov
thank you very much for your support!

At the moment I have the problems with dependencies.
vscode-ws-jsonrpc brings dependency "vscode-jsonrpc": "^4.1.0-next" version

vscode-languageclient@^6.0.0 brings vscode-languageserver-protocol "^3.15.0" => vscode-jsonrpc "^5.0.0" version.

MessageConnection of 4.1.0-next is not compatible with the object of 5.0.0 version.

As result I get errors like:
[compile] src/browser/messaging/ws-connection-provider.ts(112,34): error TS2345: Argument of type 'import("/home/rnikitenko/projects/theia/node_modules/vscode-ws-jsonrpc/node_modules/vscode-jsonrpc/lib/main").MessageConnection' is not assignable to parameter of type 'import("/home/rnikitenko/projects/theia/node_modules/vscode-jsonrpc/lib/main").MessageConnection'.

So at the current step I'm looking for correct way to fix this problem.

akosyakov · 2020-01-28T06:58:15Z

@RomanNikitenko we need a new version of vscode-ws-jsonrpc then with 5.0.0. We will have the same issue in Theia.

Added you as an admin there: https://github.com/TypeFox/vscode-ws-jsonrpc just ping me when i have to make a new release

akosyakov · 2020-02-03T10:31:47Z

@RomanNikitenko published vscode-ws-jsonrpc@0.2.0, you should be able to use it now

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

akosyakov · 2020-02-06T11:43:07Z

@RomanNikitenko Let me know if you need any other support. Usually we will do a dev release from the PR, open a PR for Theia against dev version and test it there.

RomanNikitenko · 2020-02-06T19:50:04Z

@akosyakov
About dev release - is it OK if within testing dev version I find something that we have to fix in monaco-languageclient repo and prepare another dev version?

I could test it locally first: add for theia repo dependency on these changes like:
"monaco-languageclient": "file:../../../monaco-languageclient/client",

Also for testing it for theia repo I need:

Upgrade TypeFox/monaco-editor-core to the latest Microsoft/monaco-editor-core

akosyakov · 2020-02-07T06:32:57Z

About dev release - is it OK if within testing dev version I find something that we have to fix in monaco-languageclient repo and prepare another dev version

@RomanNikitenko yes, that's an idea. I will publish it today then?

Upgrade TypeFox/monaco-editor-core to the latest Microsoft/monaco-editor-core

I will do it for you today.

RomanNikitenko · 2020-02-07T07:12:58Z

@akosyakov

@RomanNikitenko yes, that's an idea. I will publish it today then?

I would like to pick up the changes from the PR #191 to have ability to test them as well on dev version for theia.
WDYT?

If you don't mind I can merge the changes from the specified PR to my draft PR.

akosyakov · 2020-02-07T08:17:52Z

@RomanNikitenko yes, it is fine

RomanNikitenko · 2020-02-07T09:12:54Z

@akosyakov
I merged the specified PR changes to the current PR.

I think this one for testing goals only and we can streamline the commits when we are ready to merge these changes to master.
Please, let me know if we need to streamline the commits right now.

akosyakov · 2020-02-07T09:29:30Z

there's going to be Monaco 0.20.x soon 🙈 https://github.com/microsoft/vscode/tree/standalone/0.20.x

Should we rather go for it instead?

akosyakov · 2020-02-07T10:04:15Z

Let's stick with 0.19.

akosyakov · 2020-02-07T10:59:12Z

Published dev tag from this branch:

Successfully published:

monaco-languageclient@0.11.1-dev.4+6590ed7

Published 0.19.3 monaco from https://github.com/theia-ide/vscode/tree/standalone/0.19.x

@theia/monaco-editor-core@0.19.3

RomanNikitenko · 2020-02-07T11:01:55Z

@akosyakov
thank you very much!

I'll apply these versions for theia repo and prepare the corresponding PR for testing.

akosyakov · 2020-02-07T11:07:17Z

@RomanNikitenko just open it is as a draft, we can collaborate on it, i.e. i can help writing integration tests while you are fixing others :) more of such we have less work it would be to migrate next time

CGNonofr · 2020-03-02T13:57:08Z

It seems we have an issue in the vscode-compatibility (vscode-api.ts): the workspaceFolders getter returns a new list containing a new Uri every time.

The consequence is that a DidChangeWorkspaceFoldersNotification is sent at startup, with an identical added and removed (same Uri but a different instance) and some LSP implementations don't like that at all!

akosyakov · 2020-03-19T15:13:58Z

@RomanNikitenko I want to merge it and make a new release. Could you open for a review it please?

akosyakov

thank you @RomanNikitenko

NLueg and others added 7 commits December 6, 2019 12:15

converter: implemented asDefinitionResult for DefinitionLinks

34d4ee5

added fix for vscode-issues #58649

c8dec80

added falsely deleted undefined for "asDefinitionResult" method

712be53

Merge branch 'master' of https://github.com/TypeFox/monaco-languagecl…

03b309c

…ient into TypeFox-master

Merged conflict of latest changes

2b9bb22

Bump Monaco to 0.19.3

1ad66b5

A new enum has been added to the vscode compatibility layer (as vscode-languageserver rely on it). Also the severity enum converter use an internal version of the enum to avoid relying on the vscode module.

Fix errors

24642b4

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

RomanNikitenko mentioned this pull request Jan 24, 2020

Bump Monaco to 0.19.3 #198

Closed

Fix file-loader version

9269688

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

RomanNikitenko force-pushed the bumpMonacoVersion branch from a0da73d to 9269688 Compare January 24, 2020 10:04

Merge branch 'master' into master

9714923

This was referenced Jan 28, 2020

Upgrade to vscode-jsonrpc 5.0.0 TypeFox/vscode-ws-jsonrpc#17

Closed

Bump node, vscode-jsonrpc and typescript versions TypeFox/vscode-ws-jsonrpc#18

Merged

Bump vscode-ws-jsonrpc version

1cf39d6

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

Merge branch 'locationLink' into bumpMonacoVersion

6590ed7

RomanNikitenko mentioned this pull request Feb 14, 2020

Upgrade to LSP 6.0.0 and Monaco 0.19.3 eclipse-theia/theia#7149

Merged

60 tasks

azatsarynnyy mentioned this pull request Feb 17, 2020

Editors Sprint 179 eclipse-che/che#15902

Closed

20 tasks

apupier mentioned this pull request Mar 12, 2020

DRAFT - Update Language Client to 6.0.0 #197

Closed

RomanNikitenko marked this pull request as ready for review March 19, 2020 15:45

RomanNikitenko requested review from akosyakov, AlexTugarev, asual, azatsarynnyy, BroKun, gatesn, johnwiseheart, mofux and rcjsuen as code owners March 19, 2020 15:45

RomanNikitenko changed the title ~~[DRAFT] Bump monaco version~~ Bump monaco version Mar 19, 2020

akosyakov approved these changes Mar 19, 2020

View reviewed changes

akosyakov merged commit 95c9925 into master Mar 19, 2020

akosyakov deleted the bumpMonacoVersion branch March 19, 2020 18:05

This was referenced Mar 20, 2020

migrate to monaco 0.19.x #194

Closed

Upgrade to vscode-language-client 6.0.0 #196

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump monaco version #199

Bump monaco version #199

RomanNikitenko commented Jan 24, 2020 •

edited

Loading

gitpod-io-legacy-app bot commented Jan 24, 2020

akosyakov commented Jan 27, 2020

RomanNikitenko commented Jan 27, 2020 •

edited

Loading

akosyakov commented Jan 28, 2020 •

edited

Loading

akosyakov commented Feb 3, 2020

akosyakov commented Feb 6, 2020

RomanNikitenko commented Feb 6, 2020

akosyakov commented Feb 7, 2020

RomanNikitenko commented Feb 7, 2020

akosyakov commented Feb 7, 2020

RomanNikitenko commented Feb 7, 2020 •

edited

Loading

akosyakov commented Feb 7, 2020 •

edited

Loading

akosyakov commented Feb 7, 2020

akosyakov commented Feb 7, 2020

RomanNikitenko commented Feb 7, 2020

akosyakov commented Feb 7, 2020

CGNonofr commented Mar 2, 2020

akosyakov commented Mar 19, 2020

akosyakov left a comment

Bump monaco version #199

Bump monaco version #199

Conversation

RomanNikitenko commented Jan 24, 2020 • edited Loading

gitpod-io-legacy-app bot commented Jan 24, 2020

akosyakov commented Jan 27, 2020

RomanNikitenko commented Jan 27, 2020 • edited Loading

akosyakov commented Jan 28, 2020 • edited Loading

akosyakov commented Feb 3, 2020

akosyakov commented Feb 6, 2020

RomanNikitenko commented Feb 6, 2020

akosyakov commented Feb 7, 2020

RomanNikitenko commented Feb 7, 2020

akosyakov commented Feb 7, 2020

RomanNikitenko commented Feb 7, 2020 • edited Loading

akosyakov commented Feb 7, 2020 • edited Loading

akosyakov commented Feb 7, 2020

akosyakov commented Feb 7, 2020

RomanNikitenko commented Feb 7, 2020

akosyakov commented Feb 7, 2020

CGNonofr commented Mar 2, 2020

akosyakov commented Mar 19, 2020

akosyakov left a comment

Choose a reason for hiding this comment

RomanNikitenko commented Jan 24, 2020 •

edited

Loading

RomanNikitenko commented Jan 27, 2020 •

edited

Loading

akosyakov commented Jan 28, 2020 •

edited

Loading

RomanNikitenko commented Feb 7, 2020 •

edited

Loading

akosyakov commented Feb 7, 2020 •

edited

Loading