Upgrade to vscode-language-client 6.0.0 #196
Assignees
Labels
Comments
|
@azatsarynnyy @RomanNikitenko It would be nice to make together with upgrade to latest Monaco, without going over everything twice. |
6 tasks
apupier
added a commit
to apupier/monaco-languageclient
that referenced
this issue
Jan 21, 2020
- requires upgrade of TtypeScript to 3.7.5 to avoid "error TS1086: An
accessor cannot be declared in an ambient context.
"
- requires API updates:
-- client/src/monaco-language-client.ts createMessageTransports now
using Promise instead of Thenable
-- vscode-uri Uri has been renamed URI
-- registerCallHierarchyProvider has moved from workspace to languages
remaining:
monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.
monaco-languageclient: src/vscode-api.ts(209,17): error TS2322: Type
'(arg0: Uri, arg1: readonly Diagnostic[] | undefined) => void' is not
assignable to type '{ (uri: Uri, diagnostics: readonly Diagnostic[] |
undefined): void; (entries: readonly [Uri, readonly Diagnostic[] |
undefined][]): void; }'.
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/monaco-languageclient
that referenced
this issue
Jan 21, 2020
monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/monaco-languageclient
that referenced
this issue
Jan 21, 2020
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
20 tasks
16 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
closed by #199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
it would be nice to upgrade to 6.0.0
https://github.com/Microsoft/vscode-languageserver-node/blob/master/README.md#3150-protocol-600-client--600-server
there is especially fixed devDependencies to make it easier to use:
https://github.com/microsoft/vscode-languageserver-node/blob/0b7a2b3c3f00c596fe799b31d6a34a594a53e26b/client/package.json#L22
https://github.com/microsoft/vscode-languageserver-node/blob/a61f308d22a54c4e187b01fda00f061cf21b184c/client/package.json#L22
The text was updated successfully, but these errors were encountered: