Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create editor context menu based on context #7368

Open
RomanNikitenko opened this issue Mar 19, 2020 · 0 comments
Open

Create editor context menu based on context #7368

RomanNikitenko opened this issue Mar 19, 2020 · 0 comments
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Mar 19, 2020

Description

At the moment editor context menu is created only once and reused for all editors.
As result we have the same context menu for different editors:
https://youtu.be/kmZeuxAfe_I

As improvement editor context menu should be created based on current context on each call.
The issue based on #7149 (comment)

Reproduction Steps

Try to use editor context menu for different types of editors.
Pay attention on items and that some of them are disabled.
Also see the short video above.

OS and Theia version:
Fedora 31
Theia: 5fb75c7

@RomanNikitenko RomanNikitenko added enhancement issues that are enhancements to current functionality - nice to haves editor issues related to the editor monaco issues related to monaco labels Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco
Projects
None yet
Development

No branches or pull requests

1 participant