Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Monaco 0.20.0 #7697

Closed
akosyakov opened this issue Apr 29, 2020 · 10 comments · Fixed by #8010
Closed

upgrade to Monaco 0.20.0 #7697

akosyakov opened this issue Apr 29, 2020 · 10 comments · Fixed by #8010
Assignees
Labels
monaco issues related to monaco Team: Che-Editors issues regarding the che-editors team

Comments

@akosyakov
Copy link
Member

It's required to support semantic highlighting, for instance to run latest rust extension: #7608

There are 2 ways:

@akosyakov akosyakov added monaco issues related to monaco help wanted issues meant to be picked up, require help labels Apr 29, 2020
@azatsarynnyy
Copy link
Member

Hi @akosyakov
probably, we (at Red Hat) can work on it starting next week, by doing it as the previous Monaco migration.
I'll let you know here by Friday, May 8.

@azatsarynnyy
Copy link
Member

We need a couple of more days to finalize our plans for May. So, I will come back next week with more accurate dates.

@azatsarynnyy
Copy link
Member

We'll work on it during May. Most likely, starting next week.

@azatsarynnyy azatsarynnyy added Team: Che-Editors issues regarding the che-editors team and removed help wanted issues meant to be picked up, require help labels May 13, 2020
@llebout
Copy link

llebout commented May 13, 2020

Cool! Thanks @azatsarynnyy - rust-analyzer support (requiring newer Monaco) will be awesome!!

@azatsarynnyy
Copy link
Member

@Leo-LB I wonder are you interested in some features of newer Monaco or more in Plugin APIs that we'll be able to implement after the upgrade?

@llebout
Copy link

llebout commented May 18, 2020

@azatsarynnyy the latter - see: #7608

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented May 20, 2020

@akosyakov
I'm ready to take this issue in progress, if you don't mind.

Please let me know if you have some things I should pay attention.
From my side I remember:

I'll add these items to my TODO list when I have the corresponding PR in Theia

@RomanNikitenko
Copy link
Contributor

@akosyakov
I see you published next version of monaco-languageclient.

Can I ask you publish 0.20 version of @theia/monaco-editor-core when you have a chance.

Then I can apply these versions for Theia and open a draft PR for testing and adaptation.

@akosyakov
Copy link
Member Author

@RomanNikitenko Hi, I will do tomorrow morning.

@akosyakov
Copy link
Member Author

Published https://www.npmjs.com/package/@theia/monaco-editor-core/v/0.20.0 from https://github.com/theia-ide/vscode/commits/standalone/0.20.x

Recap for next time:

git checkout --track origin/standalone/0.20.x
  • sync latest changes from upstream tag
git reset --hard upstream/standalone/0.20.x
git push -f
  • run yarn to install dependencies
  • prepare distribution with /src/vscode> node_modules/.bin/gulp editor-distro
  • publish with npm publish

Relevant VS Code docs: https://github.com/microsoft/monaco-editor/blob/master/CONTRIBUTING.md#1-ship-a-new-monaco-editor-core-npm-module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco Team: Che-Editors issues regarding the che-editors team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants