Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monaco][quick-open] Using fuzzySort: true throws an error #7899

Closed
RomanNikitenko opened this issue May 26, 2020 · 7 comments · Fixed by #8185
Closed

[monaco][quick-open] Using fuzzySort: true throws an error #7899

RomanNikitenko opened this issue May 26, 2020 · 7 comments · Fixed by #8185
Assignees
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco Team: Che-Editors issues regarding the che-editors team

Comments

@RomanNikitenko
Copy link
Contributor

Steps to Reproduce:

1. F1 --> Variable:List All
2. You can see empty list and an error in browser console

Actual behavior:
variables_actual

Expected behavior:
variables_expected

Additional Information

This place should be revisited at the next upgrade Monaco version.

The workaround is: use here false instead.

  • Operating System: Fedora 31
  • Theia Version: 84408de
@RomanNikitenko RomanNikitenko added bug bugs found in the application monaco issues related to monaco labels May 26, 2020
@akosyakov
Copy link
Member

@RomanNikitenko Do you take care about it?

@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented May 27, 2020

@akosyakov
Do you mean apply the workaround or more complex solution?

Within upgrade Monaco I'm going to investigate what VS Code uses instead compareEntries. But my question - should we apply the workaround right now, before upgrade Monaco.
Or maybe another solution is available before upgrade Monaco.

@akosyakov
Copy link
Member

akosyakov commented May 27, 2020

Do you mean apply the workaround or more complex solution?

I hoped for the solution. If not I can have a look. Upgrade will take a while.

@RomanNikitenko
Copy link
Contributor Author

@akosyakov
I didn't find a good solution quickly and I don't see how to fix it before Theia release, that's why I created the issue.
So if you see a solution, please do it.

@danieltomasku
Copy link
Contributor

I am also getting the same error when using the QuickOpenService with fuzzySort: true:
image

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jun 2, 2020
@akosyakov akosyakov changed the title Variable:List All command is not working [monaco][quick-open] Using fuzzySort: true throws an error Jun 15, 2020
@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented Jun 26, 2020

I investigated the problem, this function was removed from VS Code.

The function provided ability to sort quick open entries respecting highlight info.
So, it contained two parts:

I tried to solve the problem by :

  • provide on Theia side logic to compare label highlights
  • then use compareAnything function of VS Code

But I faced with the problem: Monaco loader did not bring comparers despite I added the corresponding items to Monaco loader here, so we can not reuse compareAnything function of VS Code.

@akosyakov
Copy link
Member

We coudl either drop it if it is not used much or copy missing functions via CQs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco Team: Che-Editors issues regarding the che-editors team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants