Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support overwriting the label of detected tasks #6507

Closed
elaihau opened this issue Nov 7, 2019 · 3 comments · Fixed by #7574
Closed

support overwriting the label of detected tasks #6507

elaihau opened this issue Nov 7, 2019 · 3 comments · Fixed by #7574
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@elaihau
Copy link
Contributor

elaihau commented Nov 7, 2019

Description

It would be nice if overwriting the labels of detected tasks is supported in Theia.

Reproduction Steps

It is a feature in vs code. Users are able to replace the label of a detected task with a custom one by add "label" property in the config.

See GIF below to see how it works in vs code:

Peek 2019-11-06 23-58

OS and Theia version:

Ubuntu 18.04. Example browser.

Version 0e16fe0

Diagnostics:

In theia, we don't handle the "label" property in TaskCustomization properly.

@elaihau elaihau added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system labels Nov 7, 2019
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Nov 7, 2019
@lmcbout
Copy link
Contributor

lmcbout commented Nov 7, 2019

I also noticed that the task are being kept in the local storage. So when you restart the application, the "label" of the task remains even if you removed the label from the tasks.json

@elaihau elaihau self-assigned this Nov 8, 2019
@elaihau elaihau removed their assignment Nov 21, 2019
@tsmaeder
Copy link
Contributor

tsmaeder commented Apr 7, 2020

@lmcbout that would be quite a different error than what this issue is about. Could you open a separate issue with steps to reproduce, please?

@lmcbout
Copy link
Contributor

lmcbout commented Apr 8, 2020

@tsmaeder I tried to reproduce the issue I reported last november with the latest Theia 1.0. I could not. If ever I can reproduce it, I will raise a new issue with steps to reproduce.

@elaihau elaihau self-assigned this Apr 13, 2020
elaihau added a commit that referenced this issue Apr 14, 2020
- With this change users would be able to define labels in the task configs to overwrite the task names from providers.
- fixes #6507
- fixes #7515

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Apr 16, 2020
- With this change users would be able to define labels in the task configs to overwrite the task names from providers.
- fixes #6507
- fixes #7515

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Apr 16, 2020
- With this change users would be able to define labels in the task configs to overwrite the task names from providers.
- fixes #6507
- fixes #7515

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants