Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui/ux] toolbar icons missing in apps with a limited set of dependencies #6513

Closed
vince-fugnitto opened this issue Nov 7, 2019 · 0 comments · Fixed by #6514
Closed

[ui/ux] toolbar icons missing in apps with a limited set of dependencies #6513

vince-fugnitto opened this issue Nov 7, 2019 · 0 comments · Fixed by #6514
Labels
question user / developer questions toolbar issues related to the toolbar ui/ux issues related to user interface / user experience

Comments

@vince-fugnitto
Copy link
Member

Description

Throughout the application we have toolbar item icons which can be used by multiple extensions (ex: clear-all). The only problem is that if for instance the extension that provides the icon is not added to an application, the icon will not be displayed. I believe for these cases, global icons should be displayed in core for others to use.

As an example, here is clear-all:

It's CSS styling as a toolbar item is being defined in search-in-workspace:

theia/packages/search-in-workspace/src/browser/styles/index.css

Lines 76 to 78 in 9161b50

.p-TabBar-toolbar .item .clear-all {
background: var(--theia-icon-clear) no-repeat;
}

And re-used:

theia/packages/debug/src/browser/console/debug-console-contribution.tsx

Line 36 in 9161b50

iconClass: 'clear-all'

theia/packages/keymaps/src/browser/keymaps-frontend-contribution.ts

Line 50 in 9161b50

iconClass: 'clear-all'

theia/packages/output/src/browser/output-contribution.ts

Line 29 in 9161b50

iconClass: 'clear-all'

@vince-fugnitto vince-fugnitto added question user / developer questions ui/ux issues related to user interface / user experience toolbar issues related to the toolbar labels Nov 7, 2019
vince-fugnitto added a commit that referenced this issue Nov 7, 2019
@vince-fugnitto
Fix display of toolbar item icons
7eaa309 
Fixes #6513

- fixes the display of toolbar item icons when applications are created
with a subset of available extensions. The common icons are added to core
for others to use.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Nov 7, 2019
Merged
1 task
@vince-fugnitto vince-fugnitto changed the title [ui/ux] what is the plan for icons? [ui/ux] toolbar icons missing in apps with a limited set of dependencies Nov 7, 2019
vince-fugnitto added a commit that referenced this issue Nov 12, 2019
@vince-fugnitto
Fix display of toolbar item icons
a341032 
Fixes #6513

- fixes the display of toolbar item icons when applications are created
with a subset of available extensions. The common icons are added to core
for others to use.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
Fix display of toolbar item icons
d22660d 
Fixes eclipse-theia#6513

- fixes the display of toolbar item icons when applications are created
with a subset of available extensions. The common icons are added to core
for others to use.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question user / developer questions toolbar issues related to the toolbar ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] fix display of toolbar item icons eclipse-theia/theia
1 participant
@vince-fugnitto